cache url

Author: Mpdreamz

src/Elastic.Documentation.Navigation/Assembler/AssembledNavigation.cs

@@ -209,7 +209,7 @@ void IAssignableChildrenNavigation.SetNavigationItems(IReadOnlyCollection<INavig
 		// Set the navigation index
 		node.Parent = parent;
 		node.NavigationIndex = index;
-		homeAccessor.HomeProvider = new NavigationHomeProvider(pathPrefix, root, true);
+		homeAccessor.HomeProvider = new NavigationHomeProvider(pathPrefix, root);
 
 		//var wrapped = new SiteTableOfContentsNavigation<IDocumentationFile>(node, homeAccessor.HomeProvider, parent, root);
 		//parent = wrapped;

src/Elastic.Documentation.Navigation/Isolated/DocumentationSetNavigation.cs

@@ -96,8 +96,6 @@ public DocumentationSetNavigation(
 	/// </summary>
 	public string PathPrefix => HomeProvider == this ? _pathPrefix : HomeProvider.PathPrefix;
 
-	bool INavigationHomeProvider.RelativeToTableOfContents => false;
-
 	public INavigationHomeProvider HomeProvider { get; set; }
 
 	public GitCheckoutInformation Git { get; }
@@ -379,7 +377,7 @@ int depth
 			context.ReadFileSystem.Path.Combine(context.DocumentationSourceDirectory.FullName, fullTocPath)
 		);
 
-		var isolatedHomeProvider = new NavigationHomeProvider(homeAccessor.HomeProvider.PathPrefix, homeAccessor.HomeProvider.NavigationRoot, homeAccessor.HomeProvider.RelativeToTableOfContents);
+		var isolatedHomeProvider = new NavigationHomeProvider(homeAccessor.HomeProvider.PathPrefix, homeAccessor.HomeProvider.NavigationRoot);
 
 		// Create the TOC navigation with empty children initially
 		// We use null parent temporarily - we'll set it properly at the end using the public setter

src/Elastic.Documentation.Navigation/Isolated/FileNavigationLeaf.cs

@@ -24,13 +24,19 @@ public class FileNavigationLeaf<TModel>(TModel model, IFileInfo fileInfo, FileNa
 	public IFileInfo FileInfo { get; } = fileInfo;
 
 	/// <inheritdoc />
-	public TModel Model { get; init; } = model;
+	public TModel Model { get; } = model;
+
+	private string? _homeProviderCache;
+	private string? _urlCache;
 
 	/// <inheritdoc />
 	public string Url
 	{
 		get
 		{
+			if (_homeProviderCache is not null && _homeProviderCache == args.HomeAccessor.HomeProvider.Id && _urlCache is not null)
+				return _urlCache;
+
 			var rootUrl = args.HomeAccessor.HomeProvider.PathPrefix.TrimEnd('/');
 			var relativeToContainer = args.HomeAccessor.HomeProvider.NavigationRoot.Parent is SiteNavigation;
 
@@ -49,12 +55,15 @@ public string Url
 			if (string.IsNullOrEmpty(path))
 				return string.IsNullOrEmpty(rootUrl) ? "/" : rootUrl;
 
-			return $"{rootUrl}/{path}";
+			_homeProviderCache = args.HomeAccessor.HomeProvider.Id;
+			_urlCache = $"{rootUrl}/{path}";
+
+			return _urlCache;
 		}
 	}
 
 	/// <inheritdoc />
-	public bool Hidden { get; init; } = args.Hidden;
+	public bool Hidden { get; } = args.Hidden;
 
 	/// <inheritdoc />
 	public IRootNavigationItem<INavigationModel, INavigationItem> NavigationRoot => args.HomeAccessor.HomeProvider.NavigationRoot;

src/Elastic.Documentation.Navigation/Isolated/IPathPrefixProvider.cs

@@ -10,7 +10,7 @@ public interface INavigationHomeProvider
 {
 	string PathPrefix { get; }
 	IRootNavigationItem<INavigationModel, INavigationItem> NavigationRoot { get; }
-	bool RelativeToTableOfContents { get; }
+	string Id { get; }
 }
 
 public interface INavigationHomeAccessor
@@ -19,20 +19,16 @@ public interface INavigationHomeAccessor
 }
 
 [DebuggerDisplay("{PathPrefix} => {NavigationRoot.Url}")]
-public class NavigationHomeProvider(
-	string pathPrefix,
-	IRootNavigationItem<INavigationModel, INavigationItem> navigationRoot,
-	bool relativeToTableOfContents
-) : INavigationHomeProvider
+public class NavigationHomeProvider(string pathPrefix, IRootNavigationItem<INavigationModel, INavigationItem> navigationRoot) : INavigationHomeProvider
 {
 	/// <inheritdoc />
 	public string PathPrefix { get; } = pathPrefix;
 
-	public bool RelativeToTableOfContents { get; } = relativeToTableOfContents;
-
 	/// <inheritdoc />
 	public IRootNavigationItem<INavigationModel, INavigationItem> NavigationRoot { get; } = navigationRoot;
 
+	public string Id { get; } = Guid.NewGuid().ToString("N");
+
 	public override string ToString() => $"{PathPrefix} => {NavigationRoot.Url}";
 }
 

src/Elastic.Documentation.Navigation/Isolated/TableOfContentsNavigation.cs

@@ -60,8 +60,6 @@ INavigationHomeProvider homeProvider
 	/// </summary>
 	public string PathPrefix { get; }
 
-	bool INavigationHomeProvider.RelativeToTableOfContents => false;
-
 	/// <inheritdoc />
 	public string Url => Index.Url;
 

tests/Navigation.Tests/Isolation/DynamicUrlTests.cs

@@ -37,15 +37,15 @@ public void DynamicUrlUpdatesWhenRootUrlChanges()
 		file.Url.Should().Be("/setup/install");
 
 		// Change root URL
-		navigation.HomeProvider = new NavigationHomeProvider("/v8.0", navigation.NavigationRoot, false);
+		navigation.HomeProvider = new NavigationHomeProvider("/v8.0", navigation.NavigationRoot);
 
 		// URLs should update dynamically
 		// Since folder has no index child, its URL is the first child's URL
 		folder.Url.Should().Be("/v8.0/setup/install");
 		file.Url.Should().Be("/v8.0/setup/install");
 
 		// Change root URL
-		navigation.HomeProvider = new NavigationHomeProvider("/v9.0", navigation.NavigationRoot, false);
+		navigation.HomeProvider = new NavigationHomeProvider("/v9.0", navigation.NavigationRoot);
 
 		// URLs should update dynamically
 		// Since folder has no index child, its URL is the first child's URL
@@ -80,7 +80,7 @@ public void UrlRootPropagatesCorrectlyThroughFolders()
 		file.Url.Should().Be("/outer/inner/deep");
 
 		// Change root URL
-		navigation.HomeProvider = new NavigationHomeProvider("/base", navigation.NavigationRoot, false);
+		navigation.HomeProvider = new NavigationHomeProvider("/base", navigation.NavigationRoot);
 
 		file.Url.Should().Be("/base/outer/inner/deep");
 	}
@@ -277,7 +277,7 @@ public void UrlRootChangesForTableOfContentsNavigation()
 		file.Url.Should().Be("/guides/api/reference");
 
 		// Change root URL
-		navigation.HomeProvider = new NavigationHomeProvider("/v2", navigation.NavigationRoot, false);
+		navigation.HomeProvider = new NavigationHomeProvider("/v2", navigation.NavigationRoot);
 
 		// Both TOC and file URLs should update
 		toc.Url.Should().Be("/v2/guides/api/reference");

tests/Navigation.Tests/Isolation/FileNavigationTests.cs

@@ -164,7 +164,7 @@ public void FileNavigationUrlUpdatesWhenRootChanges()
 		child.Url.Should().Be("/section1");
 
 		// Change root URL
-		navigation.HomeProvider = new NavigationHomeProvider("/v2", navigation.NavigationRoot, false);
+		navigation.HomeProvider = new NavigationHomeProvider("/v2", navigation.NavigationRoot);
 
 		// URLs should update dynamically
 		fileNav.Url.Should().Be("/v2/guide");