Fix csharp code analysis warnings (#538)

* Fix csharp code analysis warnings

* fix release build

Author: Mpdreamz

src/Elastic.Markdown.Refactor/Move.cs

@@ -2,11 +2,9 @@
 // Elasticsearch B.V licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information
 
-using System.Collections.ObjectModel;
 using System.IO.Abstractions;
 using System.Text.RegularExpressions;
 using Elastic.Markdown.IO;
-using Elastic.Markdown.Slices;
 using Microsoft.Extensions.Logging;
 
 namespace Elastic.Markdown.Refactor;
@@ -291,9 +289,7 @@ private string ReplaceLinks(
 
 				string newLink;
 				if (originalPath.StartsWith('/'))
-				{
 					newLink = $"[{match.Groups[1].Value}]({absoluteStyleTarget}{anchor})";
-				}
 				else
 				{
 					var relativeTarget = Path.GetRelativePath(Path.GetDirectoryName(value.FilePath)!, target);

src/Elastic.Markdown/Diagnostics/DiagnosticsChannel.cs

@@ -5,7 +5,6 @@
 using System.Collections.Concurrent;
 using System.Threading.Channels;
 using Microsoft.Extensions.Hosting;
-using Microsoft.Extensions.Logging;
 
 namespace Elastic.Markdown.Diagnostics;
 

src/Elastic.Markdown/Diagnostics/ProcessorDiagnosticExtensions.cs

@@ -5,7 +5,6 @@
 using System.IO.Abstractions;
 using Elastic.Markdown.Myst;
 using Elastic.Markdown.Myst.Directives;
-using Markdig.Helpers;
 using Markdig.Parsers;
 using Markdig.Syntax.Inlines;
 

src/Elastic.Markdown/IO/Configuration/ConfigurationFile.cs

@@ -146,12 +146,12 @@ private List<ITocItem> ReadChildren(KeyValuePair<YamlNode, YamlNode> entry, stri
 			switch (key)
 			{
 				case "toc":
-					toc = ReadNestedToc(entry, parentPath, out fileFound);
+					toc = ReadNestedToc(entry, out fileFound);
 					break;
 				case "hidden":
 				case "file":
 					hiddenFile = key == "hidden";
-					file = ReadFile(entry, parentPath, key, out fileFound);
+					file = ReadFile(entry, parentPath, out fileFound);
 					break;
 				case "folder":
 					folder = ReadFolder(entry, parentPath, out folderFound);
@@ -230,7 +230,7 @@ private Dictionary<string, string> ReadDictionary(KeyValuePair<YamlNode, YamlNod
 		return folder;
 	}
 
-	private string? ReadFile(KeyValuePair<YamlNode, YamlNode> entry, string parentPath, string key, out bool found)
+	private string? ReadFile(KeyValuePair<YamlNode, YamlNode> entry, string parentPath, out bool found)
 	{
 		found = false;
 		var file = ReadString(entry);
@@ -247,7 +247,7 @@ private Dictionary<string, string> ReadDictionary(KeyValuePair<YamlNode, YamlNod
 		return file;
 	}
 
-	private ConfigurationFile? ReadNestedToc(KeyValuePair<YamlNode, YamlNode> entry, string parentPath, out bool found)
+	private ConfigurationFile? ReadNestedToc(KeyValuePair<YamlNode, YamlNode> entry, out bool found)
 	{
 		found = false;
 		var tocPath = ReadString(entry);

src/Elastic.Markdown/IO/MarkdownFile.cs

@@ -172,7 +172,7 @@ private void ReadDocumentInstructions(MarkdownDocument document)
 				var header = h.Item1!.StripMarkdown();
 				if (header.AsSpan().ReplaceSubstitutions(subs, out var replacement))
 					header = replacement;
-				return new PageTocItem { Heading = header!, Slug = (h.Item2 ?? header).Slugify(), Level = h.Level };
+				return new PageTocItem { Heading = header, Slug = (h.Item2 ?? header).Slugify(), Level = h.Level };
 			})
 			.ToList();
 

src/Elastic.Markdown/Myst/CodeBlocks/EnhancedCodeBlock.cs

@@ -29,7 +29,7 @@ public class EnhancedCodeBlock(BlockParser parser, ParserContext context)
 
 	public List<CallOut> CallOuts { get; set; } = [];
 
-	public IReadOnlyCollection<CallOut> UniqueCallOuts => CallOuts?.DistinctBy(c => c.Index).ToList() ?? [];
+	public IReadOnlyCollection<CallOut> UniqueCallOuts => [.. CallOuts.DistinctBy(c => c.Index)];
 
 	public bool InlineAnnotations { get; set; }
 

src/Elastic.Markdown/Myst/CodeBlocks/EnhancedCodeBlockHtmlRenderer.cs

@@ -3,7 +3,6 @@
 // See the LICENSE file in the project root for more information
 
 using Elastic.Markdown.Diagnostics;
-using Elastic.Markdown.Myst.Directives;
 using Elastic.Markdown.Slices.Directives;
 using Markdig.Helpers;
 using Markdig.Renderers;
@@ -65,7 +64,7 @@ private static void RenderCodeBlockLine(HtmlRenderer renderer, EnhancedCodeBlock
 
 	private static void RenderCallouts(HtmlRenderer renderer, EnhancedCodeBlock block, int lineNumber)
 	{
-		var callOuts = FindCallouts(block.CallOuts ?? [], lineNumber + 1);
+		var callOuts = FindCallouts(block.CallOuts, lineNumber + 1);
 		foreach (var callOut in callOuts)
 			renderer.Write($"<span class=\"code-callout\" data-index=\"{callOut.Index}\">{callOut.Index}</span>");
 	}

src/Elastic.Markdown/Myst/CodeBlocks/EnhancedCodeBlockParser.cs

@@ -103,12 +103,12 @@ public override bool Close(BlockProcessor processor, Block block)
 		if (codeBlock is not AppliesToDirective appliesToDirective)
 			ProcessCallOuts(lines, language, codeBlock, context);
 		else
-			ProcessAppliesToDirective(appliesToDirective, lines, context);
+			ProcessAppliesToDirective(appliesToDirective, lines);
 
 		return base.Close(processor, block);
 	}
 
-	private static void ProcessAppliesToDirective(AppliesToDirective appliesToDirective, StringLineGroup lines, ParserContext context)
+	private static void ProcessAppliesToDirective(AppliesToDirective appliesToDirective, StringLineGroup lines)
 	{
 		var yaml = lines.ToSlice().AsSpan().ToString();
 
@@ -195,8 +195,8 @@ private static void ProcessCallOuts(StringLineGroup lines, string language, Enha
 			}
 		}
 
-		var inlineAnnotations = codeBlock.CallOuts?.Where(c => c.InlineCodeAnnotation).Count() ?? 0;
-		var classicAnnotations = codeBlock.CallOuts?.Count - inlineAnnotations ?? 0;
+		var inlineAnnotations = codeBlock.CallOuts.Count(c => c.InlineCodeAnnotation);
+		var classicAnnotations = codeBlock.CallOuts.Count - inlineAnnotations;
 		if (inlineAnnotations > 0 && classicAnnotations > 0)
 			codeBlock.EmitError("Both inline and classic callouts are not supported");
 

src/Elastic.Markdown/Myst/CodeBlocks/EnhancedCodeMarkdownExtensions.cs

@@ -2,7 +2,6 @@
 // Elasticsearch B.V licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information
 
-using Elastic.Markdown.Myst.Directives;
 using Markdig;
 using Markdig.Parsers;
 using Markdig.Renderers;

src/Elastic.Markdown/Myst/Comments/CommentBlockParser.cs

@@ -107,7 +107,6 @@ public override BlockState TryOpen(BlockProcessor processor)
 			// The optional closing sequence of #s must be preceded by a space and may be followed by spaces only.
 			var endState = 0;
 			var countClosingTags = 0;
-			var sourceEnd = processor.Line.End;
 			for (var i = processor.Line.End;
 				 i >= processor.Line.Start - 1;
 				 i--) // Go up to Start - 1 in order to match the space after the first ###