Fix NRE when incrementally syncing with an empty remote s3 bucket (#1764)

Mpdreamz · web-flow · commit 492b5c0da41b · 2025-08-26T14:55:04.000+02:00
diff --git a/src/tooling/docs-assembler/Deploying/AwsS3SyncPlanStrategy.cs b/src/tooling/docs-assembler/Deploying/AwsS3SyncPlanStrategy.cs
@@ -109,9 +109,11 @@ private async Task<Dictionary<string, S3Object>> ListObjects(Cancel ctx = defaul
 		do
 		{
 			response = await s3Client.ListObjectsV2Async(listBucketRequest, ctx);
+			if (response is null or { S3Objects: null })
+				break;
 			objects.AddRange(response.S3Objects);
-			listBucketRequest.ContinuationToken = response?.NextContinuationToken;
-		} while (response?.IsTruncated == true);
+			listBucketRequest.ContinuationToken = response.NextContinuationToken;
+		} while (response.IsTruncated == true);
 
 		return objects.ToDictionary(o => o.Key);
 	}

Original file line number	Diff line number	Diff line change
`@@ -109,9 +109,11 @@ private async Task<Dictionary<string, S3Object>> ListObjects(Cancel ctx = defaul`
`109`	`109`	`do`
`110`	`110`	`{`
`111`	`111`	`response = await s3Client.ListObjectsV2Async(listBucketRequest, ctx);`
	`112`	`+ if (response is null or { S3Objects: null })`
	`113`	`+ break;`
`112`	`114`	`objects.AddRange(response.S3Objects);`
`113`		`- listBucketRequest.ContinuationToken = response?.NextContinuationToken;`
`114`		`- } while (response?.IsTruncated == true);`
	`115`	`+ listBucketRequest.ContinuationToken = response.NextContinuationToken;`
	`116`	`+ } while (response.IsTruncated == true);`
`115`	`117`
`116`	`118`	`return objects.ToDictionary(o => o.Key);`
`117`	`119`	`}`