Use ConcurrentBag and enhance tests

Author: reakaleek

src/Elastic.Markdown/Diagnostics/DiagnosticsChannel.cs

@@ -87,7 +87,7 @@ public class DiagnosticsCollector(ILoggerFactory loggerFactory, IReadOnlyCollect
 
 	public HashSet<string> OffendingFiles { get; } = new();
 
-	public ConcurrentDictionary<string, bool> CrossLinks { get; } = new();
+	public ConcurrentBag<string> CrossLinks { get; } = new();
 
 	public Task StartAsync(Cancel ctx)
 	{
@@ -143,7 +143,7 @@ public virtual async Task StopAsync(CancellationToken cancellationToken)
 		await Channel.Reader.Completion;
 	}
 
-	public void EmitCrossLink(string link) => CrossLinks.TryAdd(link, true);
+	public void EmitCrossLink(string link) => CrossLinks.Add(link);
 
 	public void EmitError(string file, string message, Exception? e = null)
 	{

src/Elastic.Markdown/IO/LinkReference.cs

@@ -22,8 +22,7 @@ public record LinkReference
 
 	public static LinkReference Create(DocumentationSet set)
 	{
-		var crossLinks = set.Context.Collector.CrossLinks.Select(i => i.Key).ToArray();
-
+		var crossLinks = set.Context.Collector.CrossLinks.ToHashSet().ToArray();
 		var links = set.FlatMappedFiles.Values
 			.OfType<MarkdownFile>()
 			.Select(m => m.RelativePath).ToArray();

tests/Elastic.Markdown.Tests/Inline/InlineLinkTests.cs

@@ -65,6 +65,12 @@ public void GeneratesHtml() =>
 
 	[Fact]
 	public void HasNoErrors() => Collector.Diagnostics.Should().HaveCount(0);
+
+	[Fact]
+	public void EmitsCrossLink()
+	{
+		Collector.CrossLinks.Should().HaveCount(0);
+	}
 }
 
 public class InsertPageTitleTests(ITestOutputHelper output) : LinkTestBase(output,
@@ -82,6 +88,12 @@ public void GeneratesHtml() =>
 
 	[Fact]
 	public void HasNoErrors() => Collector.Diagnostics.Should().HaveCount(0);
+
+	[Fact]
+	public void EmitsCrossLink()
+	{
+		Collector.CrossLinks.Should().HaveCount(0);
+	}
 }
 
 public class LinkReferenceTest(ITestOutputHelper output) : LinkTestBase(output,
@@ -101,6 +113,12 @@ public void GeneratesHtml() =>
 
 	[Fact]
 	public void HasNoErrors() => Collector.Diagnostics.Should().HaveCount(0);
+
+	[Fact]
+	public void EmitsCrossLink()
+	{
+		Collector.CrossLinks.Should().HaveCount(0);
+	}
 }
 
 public class CrossLinkReferenceTest(ITestOutputHelper output) : LinkTestBase(output,
@@ -126,40 +144,14 @@ public void GeneratesHtml() =>
 	public void EmitsCrossLink()
 	{
 		Collector.CrossLinks.Should().HaveCount(1);
-		Collector.CrossLinks.Should().ContainKey("kibana://index.md");
+		Collector.CrossLinks.Should().Contain("kibana://index.md");
 	}
 }
 
 public class CrossLinkTest(ITestOutputHelper output) : LinkTestBase(output,
 	"""
-	[test](kibana://index.md)
-	"""
-)
-{
-	[Fact]
-	public void GeneratesHtml() =>
-		// language=html
-		Html.Should().Contain(
-			// TODO: The link is not rendered correctly yet, will be fixed in a follow-up
-			"""<p><a href="kibana://index.html">test</a></p>"""
-		);
 
-	[Fact]
-	public void HasNoErrors() => Collector.Diagnostics.Should().HaveCount(0);
-
-	[Fact]
-	public void EmitsCrossLink()
-	{
-		Collector.CrossLinks.Should().HaveCount(1);
-		Collector.CrossLinks.Should().ContainKey("kibana://index.md");
-	}
-}
-
-public class DuplicateCrossLinkTest(ITestOutputHelper output) : LinkTestBase(output,
-	"""
-	[a](kibana://index.md)
-	[b](kibana://index.md)
-	[c](elasticsearch://index.md)
+	Go to [test](kibana://index.md)
 	"""
 )
 {
@@ -168,11 +160,7 @@ public void GeneratesHtml() =>
 		// language=html
 		Html.Should().Contain(
 			// TODO: The link is not rendered correctly yet, will be fixed in a follow-up
-			"""
-			<p><a href="kibana://index.html">a</a><br />
-			<a href="kibana://index.html">b</a><br />
-			<a href="elasticsearch://index.html">c</a></p>
-			"""
+			"""<p>Go to <a href="kibana://index.html">test</a></p>"""
 		);
 
 	[Fact]
@@ -181,9 +169,7 @@ public void GeneratesHtml() =>
 	[Fact]
 	public void EmitsCrossLink()
 	{
-		Collector.CrossLinks.Should().HaveCount(2);
-		Collector.CrossLinks.Should().ContainKey("kibana://index.md");
-		Collector.CrossLinks.Should().ContainKey("elasticsearch://index.md");
+		Collector.CrossLinks.Should().HaveCount(1);
+		Collector.CrossLinks.Should().Contain("kibana://index.md");
 	}
 }
-