TestDiagnosticsCollector improvements

Author: Mpdreamz

src/Elastic.Documentation/Diagnostics/DiagnosticsCollector.cs

@@ -97,7 +97,7 @@ public virtual async Task StopAsync(Cancel cancellationToken)
 
 	public void EmitCrossLink(string link) => CrossLinks.Add(link);
 
-	public void Write(Diagnostic diagnostic)
+	public virtual void Write(Diagnostic diagnostic)
 	{
 		IncrementSeverityCount(diagnostic);
 		Channel.Write(diagnostic);

tests/Elastic.Markdown.Tests/TestDiagnosticsCollector.cs

@@ -24,5 +24,16 @@ public class TestDiagnosticsCollector(ITestOutputHelper output)
 
 	public IReadOnlyCollection<Diagnostic> Diagnostics => _diagnostics;
 
-	protected override void HandleItem(Diagnostic diagnostic) => _diagnostics.Add(diagnostic);
+	/// <inheritdoc />
+	public override void Write(Diagnostic diagnostic)
+	{
+		IncrementSeverityCount(diagnostic);
+		_diagnostics.Add(diagnostic);
+	}
+
+	/// <inheritdoc />
+	public override DiagnosticsCollector StartAsync(Cancel ctx) => this;
+
+	/// <inheritdoc />
+	public override Task StopAsync(Cancel cancellationToken) => Task.CompletedTask;
 }

tests/Navigation.Tests/Isolation/ConstructorTests.cs

@@ -280,6 +280,7 @@ public async Task ConstructorProcessesTocYmlItemsBeforeChildrenFromNavigation()
 		await context.Collector.StopAsync(TestContext.Current.CancellationToken);
 
 		var diagnostics = context.Diagnostics;
+		context.Diagnostics.Should().HaveCount(1);
 		diagnostics.Should().Contain(d =>
 			d.Message.Contains("TableOfContents 'api' may not contain children, define children in 'api/toc.yml' instead."));
 	}

tests/Navigation.Tests/TestDocumentationSetContext.cs

@@ -32,17 +32,18 @@ public class TestDiagnosticsCollector(ITestOutputHelper output)
 
 	public IReadOnlyCollection<Diagnostic> Diagnostics => _diagnostics;
 
-	protected override void HandleItem(Diagnostic diagnostic)
+	/// <inheritdoc />
+	public override void Write(Diagnostic diagnostic)
 	{
-		_diagnostics.Add(diagnostic);
 		IncrementSeverityCount(diagnostic);
+		_diagnostics.Add(diagnostic);
 	}
 
 	/// <inheritdoc />
-	public override DiagnosticsCollector StartAsync(CancellationToken ctx) => this;
+	public override DiagnosticsCollector StartAsync(Cancel ctx) => this;
 
 	/// <inheritdoc />
-	public override Task StopAsync(CancellationToken cancellationToken) => Task.CompletedTask;
+	public override Task StopAsync(Cancel cancellationToken) => Task.CompletedTask;
 }
 
 public class TestDocumentationSetContext : IDocumentationSetContext