Remove Title property from LinkMetadata and TryGetLinkMetadata method

Co-authored-by: Mpdreamz <[email protected]>

Author: Copilot

src/Elastic.Documentation.Links/CrossLinks/CrossLinkResolver.cs

@@ -10,7 +10,6 @@ namespace Elastic.Documentation.Links.CrossLinks;
 public interface ICrossLinkResolver
 {
 	bool TryResolve(Action<string> errorEmitter, Uri crossLinkUri, [NotNullWhen(true)] out Uri? resolvedUri);
-	bool TryGetLinkMetadata(Uri crossLinkUri, [NotNullWhen(true)] out LinkMetadata? linkMetadata);
 	IUriEnvironmentResolver UriResolver { get; }
 }
 
@@ -25,13 +24,6 @@ public bool TryResolve(Action<string> errorEmitter, Uri crossLinkUri, [NotNullWh
 		return false;
 	}
 
-	/// <inheritdoc />
-	public bool TryGetLinkMetadata(Uri crossLinkUri, [NotNullWhen(true)] out LinkMetadata? linkMetadata)
-	{
-		linkMetadata = null;
-		return false;
-	}
-
 	/// <inheritdoc />
 	public IUriEnvironmentResolver UriResolver { get; } = new IsolatedBuildEnvironmentUriResolver();
 
@@ -47,20 +39,6 @@ public class CrossLinkResolver(FetchedCrossLinks crossLinks, IUriEnvironmentReso
 	public bool TryResolve(Action<string> errorEmitter, Uri crossLinkUri, [NotNullWhen(true)] out Uri? resolvedUri) =>
 		TryResolve(errorEmitter, _crossLinks, UriResolver, crossLinkUri, out resolvedUri);
 
-	public bool TryGetLinkMetadata(Uri crossLinkUri, [NotNullWhen(true)] out LinkMetadata? linkMetadata)
-	{
-		linkMetadata = null;
-
-		if (!_crossLinks.LinkReferences.TryGetValue(crossLinkUri.Scheme, out var sourceLinkReference))
-			return false;
-
-		var originalLookupPath = (crossLinkUri.Host + '/' + crossLinkUri.AbsolutePath.TrimStart('/')).Trim('/');
-		if (string.IsNullOrEmpty(originalLookupPath) && crossLinkUri.Host.EndsWith(".md", StringComparison.OrdinalIgnoreCase))
-			originalLookupPath = crossLinkUri.Host;
-
-		return sourceLinkReference.Links.TryGetValue(originalLookupPath, out linkMetadata);
-	}
-
 	public FetchedCrossLinks UpdateLinkReference(string repository, RepositoryLinks repositoryLinks)
 	{
 		var dictionary = _crossLinks.LinkReferences.ToDictionary(kvp => kvp.Key, kvp => kvp.Value);

src/Elastic.Documentation/Links/RepositoryLinks.cs

@@ -17,10 +17,6 @@ public record LinkMetadata
 	[JsonPropertyName("hidden")]
 	[JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingDefault)]
 	public bool Hidden { get; init; }
-
-	[JsonPropertyName("title")]
-	[JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
-	public string? Title { get; init; }
 }
 
 public record LinkSingleRedirect

src/Elastic.Markdown/Myst/InlineParsers/DiagnosticLinkInlineParser.cs

@@ -185,21 +185,10 @@ private static void ProcessCrossLink(LinkInline link, InlineProcessor processor,
 			 )
 			link.Url = resolvedUri.ToString();
 
-		// Handle empty link text by trying to get title from crosslink metadata
+		// Emit error for empty link text in crosslinks
 		if (link.FirstChild == null)
 		{
-			if (context.CrossLinkResolver.TryGetLinkMetadata(uri, out var linkMetadata))
-			{
-				var title = linkMetadata.Title;
-				if (!string.IsNullOrEmpty(title))
-					_ = link.AppendChild(new LiteralInline(title));
-				else
-					processor.EmitError(link, $"Crosslink '{url}' has empty link text but no title is available in metadata. Please provide explicit link text or ensure the target page has a title in the link index.");
-			}
-			else
-			{
-				processor.EmitError(link, $"Crosslink '{url}' has empty link text but metadata could not be retrieved. Please provide explicit link text.");
-			}
+			processor.EmitError(link, $"Crosslink '{url}' has empty link text. Please provide explicit link text.");
 		}
 	}
 

tests/Elastic.Markdown.Tests/Inline/InlineLinkTests.cs

@@ -173,13 +173,16 @@ Go to [](kibana://index.md)
 {
 	[Fact]
 	public void GeneratesHtml() =>
-		// language=html
+		// language=html - empty crosslinks now emit an error
 		Html.Should().Contain(
-			"""<p>Go to <a href="https://docs-v3-preview.elastic.dev/elastic/kibana/tree/main/" hx-select-oob="#main-container" preload="mousedown">Kibana Guide</a></p>"""
+			"""<p>Go to <a href="https://docs-v3-preview.elastic.dev/elastic/kibana/tree/main/" hx-select-oob="#main-container" preload="mousedown"></a></p>"""
 		);
 
 	[Fact]
-	public void HasNoErrors() => Collector.Diagnostics.Should().HaveCount(0);
+	public void HasError() =>
+		Collector.Diagnostics.Should().Contain(d =>
+			d.Severity == Severity.Error &&
+			d.Message.Contains("empty link text"));
 
 	[Fact]
 	public void EmitsCrossLink()
@@ -198,7 +201,7 @@ Go to [](kibana://get-started/index.md)
 {
 	[Fact]
 	public void GeneratesHtml() =>
-		// language=html - when no title is available, link text should remain empty
+		// language=html - empty crosslinks emit an error
 		Html.Should().Contain(
 			"""<p>Go to <a href="https://docs-v3-preview.elastic.dev/elastic/kibana/tree/main/get-started" hx-select-oob="#main-container" preload="mousedown"></a></p>"""
 		);
@@ -207,7 +210,7 @@ public void GeneratesHtml() =>
 	public void HasError() =>
 		Collector.Diagnostics.Should().Contain(d =>
 			d.Severity == Severity.Error &&
-			d.Message.Contains("empty link text but no title is available"));
+			d.Message.Contains("empty link text"));
 
 	[Fact]
 	public void EmitsCrossLink()

tests/Elastic.Markdown.Tests/TestCrossLinkResolver.cs

@@ -30,9 +30,7 @@ public TestCrossLinkResolver()
 		           	  "url_path_prefix": "/elastic/docs-content/tree/main",
 		           	  "cross_links": [],
 		           	  "links": {
-		           		"index.md": {
-		           		  "title": "Kibana Guide"
-		           		},
+		           		"index.md": {},
 		           		"get-started/index.md": {
 		           		  "anchors": [
 		           			"elasticsearch-intro-elastic-stack",
@@ -70,10 +68,4 @@ public TestCrossLinkResolver()
 
 	public bool TryResolve(Action<string> errorEmitter, Uri crossLinkUri, [NotNullWhen(true)] out Uri? resolvedUri) =>
 		CrossLinkResolver.TryResolve(errorEmitter, _crossLinks, UriResolver, crossLinkUri, out resolvedUri);
-
-	public bool TryGetLinkMetadata(Uri crossLinkUri, [NotNullWhen(true)] out LinkMetadata? linkMetadata)
-	{
-		var resolver = new CrossLinkResolver(_crossLinks, UriResolver);
-		return resolver.TryGetLinkMetadata(crossLinkUri, out linkMetadata);
-	}
 }

tests/authoring/Framework/TestCrossLinkResolver.fs

@@ -89,8 +89,5 @@ type TestCrossLinkResolver (config: ConfigurationFile) =
         member this.TryResolve(errorEmitter, crossLinkUri, [<Out>]resolvedUri : byref<Uri|null>) =
             CrossLinkResolver.TryResolve(errorEmitter, crossLinks, uriResolver, crossLinkUri, &resolvedUri)
 
-        member this.TryGetLinkMetadata(crossLinkUri, [<Out>]linkMetadata : byref<LinkMetadata|null>) =
-            let resolver = new CrossLinkResolver(crossLinks, uriResolver)
-            resolver.TryGetLinkMetadata(crossLinkUri, &linkMetadata)