Reconcile changes from main

Author: theletterf

docs/syntax/dropdowns.md

@@ -102,3 +102,39 @@ Dropdown content for ECE and ECH
 ::::
 
 :::::
+
+## Anchors and deep linking
+
+Dropdowns automatically generate anchors from their titles, allowing you to link directly to them. The anchor is created by converting the title to lowercase and replacing spaces with hyphens (slugify).
+
+For example, a dropdown with title "Installation Guide" will have the anchor `#installation-guide`.
+
+### Custom anchors
+
+You can specify a custom anchor using the `:name:` option:
+
+:::::{tab-set}
+
+::::{tab-item} Output
+
+:::{dropdown} My Dropdown
+:name: custom-anchor
+Content that can be linked to via #custom-anchor
+:::
+
+::::
+
+::::{tab-item} Markdown
+```markdown
+:::{dropdown} My Dropdown
+:name: custom-anchor
+Content that can be linked to via #custom-anchor
+:::
+```
+::::
+
+:::::
+
+### Duplicate anchors
+
+If multiple elements (dropdowns or headings) in the same document have the same anchor, the build will emit a hint warning. While this doesn't fail the build, it may cause linking issues. Ensure each dropdown has a unique title or use the `:name:` option to specify unique anchors.

src/Elastic.Documentation.Site/Assets/open-details-with-anchor.ts

@@ -12,14 +12,12 @@ export function openDetailsWithAnchor() {
             if (closestDetails && !closestDetails.open) {
                 // Only open if it's not already open by default
                 if (!closestDetails.dataset.openDefault) {
-                    if (browser.name !== 'Chrome') {
                     closestDetails.open = true
                 }
             }
 
             // Chrome automatically ensures parent content is visible, scroll immediately
             // Other browsers need manual scroll handling
-            const browser = getBrowser()
             if (browser.name !== 'Chrome') {
                 target.scrollIntoView({
                     behavior: 'instant',

tests/Elastic.Markdown.Tests/Directives/AdmonitionTests.cs

@@ -124,7 +124,7 @@ A regular paragraph.
 	public void SetsDropdownOpen() => Block!.DropdownOpen.Should().BeTrue();
 
 	[Fact]
-	public void SetsName() => Block!.Name.Should().Be("test-dropdown");
+	public void SetsCrossReferenceName() => Block!.CrossReferenceName.Should().Be("test-dropdown");
 }
 
 public class DropdownAppliesToTests(ITestOutputHelper output) : DirectiveTest<AdmonitionBlock>(output,
@@ -144,6 +144,60 @@ A regular paragraph.
 	public void SetsCustomTitle() => Block!.Title.Should().Be("This is my custom dropdown");
 
 	[Fact]
-	public void SetsAppliesTo() => Block!.AppliesTo.Should().Be("stack: ga 9.0");
+	public void SetsAppliesToDefinition() => Block!.AppliesToDefinition.Should().Be("stack: ga 9.0");
+
+	[Fact]
+	public void ParsesAppliesTo() => Block!.AppliesTo.Should().NotBeNull();
+}
+
+public class DuplicateDropdownAnchorTests(ITestOutputHelper output) : DirectiveTest(output,
+"""
+:::{dropdown} Same title
+First dropdown content
+:::
+
+:::{dropdown} Same title
+Second dropdown content
+:::
+""")
+{
+	[Fact]
+	public void ReportsHintForDuplicateAnchors()
+	{
+		Collector.Diagnostics.Should().Contain(m =>
+			m.Severity == Severity.Hint &&
+			m.Message.Contains("Duplicate anchor") &&
+			m.Message.Contains("'same-title'"));
+
+		// Should report hint for both duplicate dropdowns
+		Collector.Diagnostics.Where(m =>
+			m.Severity == Severity.Hint &&
+			m.Message.Contains("Duplicate anchor") &&
+			m.Message.Contains("'same-title'")).Should().HaveCount(2);
+	}
+}
+
+public class DuplicateDropdownAndHeadingAnchorTests(ITestOutputHelper output) : DirectiveTest(output,
+"""
+## Test Heading
+
+:::{dropdown} Test Heading
+Dropdown content with same anchor as heading
+:::
+""")
+{
+	[Fact]
+	public void ReportsHintForDuplicateAnchorsAcrossTypes()
+	{
+		Collector.Diagnostics.Should().Contain(m =>
+			m.Severity == Severity.Hint &&
+			m.Message.Contains("Duplicate anchor") &&
+			m.Message.Contains("'test-heading'"));
+
+		// Should report hint for both the heading and dropdown
+		Collector.Diagnostics.Where(m =>
+			m.Severity == Severity.Hint &&
+			m.Message.Contains("Duplicate anchor") &&
+			m.Message.Contains("'test-heading'")).Should().HaveCount(2);
 	}
 }

tests/authoring/Framework/MarkdownDocumentAssertions.fs

@@ -34,9 +34,12 @@ module MarkdownDocumentAssertions =
         match matter with
         | NonNull m ->
             match expectedAvailability with
-            | NonNull a -> m.AppliesTo.Diagnostics <- a.Diagnostics
+            | NonNull a ->
+                match m.AppliesTo with
+                | NonNull appliesTo -> appliesTo.Diagnostics <- a.Diagnostics
+                | _ -> ()
             | _ -> ()
-                
+
             let apply = m.AppliesTo
             test <@ apply = expectedAvailability @>
         | _ -> failwithf $"%s{result.File.RelativePath} has no yamlfront matter"

tests/authoring/FrontMatter/ProductsFrontMatter.fs

@@ -68,14 +68,17 @@ This is a test page without products frontmatter.
         let defaultFile = results.MarkdownResults |> Seq.find (fun r -> r.File.RelativePath = "index.md")
 
         // Test that the file has the correct products
-        test <@ defaultFile.File.YamlFrontMatter <> null @>
-        test <@ defaultFile.File.YamlFrontMatter.Products <> null @>
-        test <@ defaultFile.File.YamlFrontMatter.Products.Count = 2 @>
-        
-        // Test that the products are correctly identified
-        let productIds = defaultFile.File.YamlFrontMatter.Products |> Seq.map (fun p -> p.Id) |> Set.ofSeq
-        test <@ productIds.Contains("elasticsearch") @>
-        test <@ productIds.Contains("ecctl") @>
+        match defaultFile.File.YamlFrontMatter with
+        | NonNull fm ->
+            match fm.Products with
+            | NonNull products ->
+                test <@ products.Count = 2 @>
+                // Test that the products are correctly identified
+                let productIds = products |> Seq.map (fun p -> p.Id) |> Set.ofSeq
+                test <@ productIds.Contains("elasticsearch") @>
+                test <@ productIds.Contains("ecctl") @>
+            | _ -> failwith "Products should not be null"
+        | _ -> failwith "YamlFrontMatter should not be null"
 
     [<Fact>]
     let ``does not include products in frontmatter when no products are specified`` () =
@@ -84,4 +87,9 @@ This is a test page without products frontmatter.
         let defaultFile = results.MarkdownResults |> Seq.find (fun r -> r.File.RelativePath = "index.md")
 
         // Test that the file has no products
-        test <@ defaultFile.File.YamlFrontMatter = null || defaultFile.File.YamlFrontMatter.Products = null || defaultFile.File.YamlFrontMatter.Products.Count = 0 @>
+        match defaultFile.File.YamlFrontMatter with
+        | NonNull fm ->
+            match fm.Products with
+            | NonNull products -> test <@ products.Count = 0 @>
+            | _ -> () // null is acceptable
+        | _ -> () // null is acceptable