Temporarily make variables with spaces that are not found hints, we used to not do anything here

Author: Mpdreamz

src/Elastic.Markdown/Diagnostics/ProcessorDiagnosticExtensions.cs

@@ -14,32 +14,24 @@ public static class ProcessorDiagnosticExtensions
 {
 	private static string CreateExceptionMessage(string message, Exception? e) => message + (e != null ? Environment.NewLine + e : string.Empty);
 
-	public static void EmitError(this InlineProcessor processor, int line, int column, int length, string message)
-	{
-		var context = processor.GetContext();
-		if (context.SkipValidation)
-			return;
-		var d = new Diagnostic
-		{
-			Severity = Severity.Error,
-			File = processor.GetContext().MarkdownSourcePath.FullName,
-			Column = column,
-			Line = line,
-			Message = message,
-			Length = length
-		};
-		context.Build.Collector.Write(d);
-	}
+	public static void EmitError(this InlineProcessor processor, int line, int column, int length, string message) =>
+		processor.Emit(Severity.Error, line, column, length, message);
 
 
-	public static void EmitWarning(this InlineProcessor processor, int line, int column, int length, string message)
+	public static void EmitWarning(this InlineProcessor processor, int line, int column, int length, string message) =>
+		processor.Emit(Severity.Warning, line, column, length, message);
+
+	public static void EmitHint(this InlineProcessor processor, int line, int column, int length, string message) =>
+		processor.Emit(Severity.Hint, line, column, length, message);
+
+	public static void Emit(this InlineProcessor processor, Severity severity, int line, int column, int length, string message)
 	{
 		var context = processor.GetContext();
 		if (context.SkipValidation)
 			return;
 		var d = new Diagnostic
 		{
-			Severity = Severity.Warning,
+			Severity = severity,
 			File = processor.GetContext().MarkdownSourcePath.FullName,
 			Column = column,
 			Line = line,

src/Elastic.Markdown/Myst/InlineParsers/Substitution/SubstitutionParser.cs

@@ -9,6 +9,7 @@
 using System.Text;
 using System.Text.Json;
 using Elastic.Documentation;
+using Elastic.Documentation.Diagnostics;
 using Elastic.Markdown.Diagnostics;
 using Markdig.Helpers;
 using Markdig.Parsers;
@@ -209,7 +210,8 @@ public override bool Match(InlineProcessor processor, ref StringSlice slice)
 		};
 
 		if (!found)
-			processor.EmitError(line + 1, column + 3, substitutionLeaf.Span.Length - 3, $"Substitution key {{{key}}} is undefined");
+			// We temporarily diagnose variable spaces as hints. We used to not read this at all.
+			processor.Emit(key.Contains(' ') ? Severity.Error : Severity.Hint, line + 1, column + 3, substitutionLeaf.Span.Length - 3, $"Substitution key {{{key}}} is undefined");
 		else
 		{
 			List<SubstitutionMutation>? mutations = null;