Skip to content

Commit 72b9429

Browse files
committed
Refactor
1 parent bca5eb4 commit 72b9429

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

src/Elastic.Markdown/HtmlWriter.cs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,9 @@ private async Task<RenderResult> RenderLayout(MarkdownFile markdown, MarkdownDoc
114114
fullNavigationRenderResult
115115
);
116116

117-
var structuredBreadcrumbsJson = CreateStructuredBreadcrumbsData(markdown, parents);
117+
var breadcrumbsList = CreateStructuredBreadcrumbsData(markdown, parents);
118+
var structuredBreadcrumbsJsonString = JsonSerializer.Serialize(breadcrumbsList, BreadcrumbsContext.Default.BreadcrumbsList);
119+
118120

119121
var slice = Page.Index.Create(new IndexViewModel
120122
{
@@ -150,7 +152,7 @@ private async Task<RenderResult> RenderLayout(MarkdownFile markdown, MarkdownDoc
150152
VersionDropdownItems = VersionDrownDownItemViewModel.FromLegacyPageMappings(legacyPages?.Skip(1).ToArray()),
151153
Products = allProducts,
152154
VersionsConfig = DocumentationSet.Context.VersionsConfiguration,
153-
StructuredBreadcrumbsJson = structuredBreadcrumbsJson
155+
StructuredBreadcrumbsJson = structuredBreadcrumbsJsonString
154156
});
155157

156158
return new RenderResult
@@ -162,7 +164,7 @@ private async Task<RenderResult> RenderLayout(MarkdownFile markdown, MarkdownDoc
162164

163165
}
164166

165-
private string CreateStructuredBreadcrumbsData(MarkdownFile markdown, INavigationItem[] parents)
167+
private BreadcrumbsList CreateStructuredBreadcrumbsData(MarkdownFile markdown, INavigationItem[] parents)
166168
{
167169
List<BreadcrumbListItem> breadcrumbItems = [];
168170
var position = 1;
@@ -185,8 +187,7 @@ private string CreateStructuredBreadcrumbsData(MarkdownFile markdown, INavigatio
185187
{
186188
ItemListElement = breadcrumbItems
187189
};
188-
var structuredBreadcrumbsJson = JsonSerializer.Serialize(breadcrumbsList, BreadcrumbsContext.Default.BreadcrumbsList);
189-
return structuredBreadcrumbsJson.Trim();
190+
return breadcrumbsList;
190191
}
191192

192193
public async Task<MarkdownDocument> WriteAsync(IDirectoryInfo outBaseDir, IFileInfo outputFile, MarkdownFile markdown, IConversionCollector? collector, Cancel ctx = default)

0 commit comments

Comments
 (0)