Ensure clone-all starts error collection (#1224)

Author: Mpdreamz

src/tooling/docs-assembler/Cli/NavigationCommands.cs

@@ -34,9 +34,8 @@ private void AssignOutputLogger()
 	public async Task<int> Validate(Cancel ctx = default)
 	{
 		AssignOutputLogger();
-		await using var collector = new ConsoleDiagnosticsCollector(logger, githubActionsService);
+		await using var collector = new ConsoleDiagnosticsCollector(logger, githubActionsService).StartAsync(ctx);
 		var assembleContext = new AssembleContext("dev", collector, new FileSystem(), new FileSystem(), null, null);
-		_ = collector.StartAsync(ctx);
 
 		// this validates all path prefixes are unique, early exit if duplicates are detected
 		if (!GlobalNavigationFile.ValidatePathPrefixes(assembleContext) || assembleContext.Collector.Errors > 0)
@@ -64,8 +63,7 @@ public async Task<int> ValidateLocalLinkReference([Argument] string? file = null
 		AssignOutputLogger();
 		file ??= ".artifacts/docs/html/links.json";
 
-		await using var collector = new ConsoleDiagnosticsCollector(logger, githubActionsService);
-		_ = collector.StartAsync(ctx);
+		await using var collector = new ConsoleDiagnosticsCollector(logger, githubActionsService).StartAsync(ctx);
 
 		var assembleContext = new AssembleContext("dev", collector, new FileSystem(), new FileSystem(), null, null);
 

src/tooling/docs-assembler/Cli/RepositoryCommands.cs

@@ -51,7 +51,7 @@ public async Task<int> CloneAll(
 		var githubEnvironmentInput = githubActionsService.GetInput("environment");
 		environment ??= !string.IsNullOrEmpty(githubEnvironmentInput) ? githubEnvironmentInput : "dev";
 
-		await using var collector = new ConsoleDiagnosticsCollector(logger, githubActionsService);
+		await using var collector = new ConsoleDiagnosticsCollector(logger, githubActionsService).StartAsync(ctx);
 
 		var assembleContext = new AssembleContext(environment, collector, new FileSystem(), new FileSystem(), null, null);
 		var cloner = new AssemblerRepositorySourcer(logger, assembleContext);
@@ -85,9 +85,7 @@ public async Task<int> BuildAll(
 		await using var collector = new ConsoleDiagnosticsCollector(logger, githubActionsService)
 		{
 			NoHints = true
-		};
-
-		_ = collector.StartAsync(ctx);
+		}.StartAsync(ctx);
 
 		var assembleContext = new AssembleContext(environment, collector, new FileSystem(), new FileSystem(), null, null)
 		{

tests/docs-assembler.Tests/src/docs-assembler.Tests/GlobalNavigationTests.cs

@@ -249,8 +249,7 @@ public async Task UriResolving()
 	{
 		Assert.SkipUnless(HasCheckouts(), $"Requires local checkout folder: {CheckoutDirectory.FullName}");
 
-		await using var collector = new DiagnosticsCollector([]);
-		_ = collector.StartAsync(TestContext.Current.CancellationToken);
+		await using var collector = new DiagnosticsCollector([]).StartAsync(TestContext.Current.CancellationToken);
 
 		var fs = new FileSystem();
 		var assembleContext = new AssembleContext("prod", collector, fs, fs, null, null);