It's working

Author: theletterf

src/Elastic.Documentation.Site/Elastic.Documentation.Site.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk.Razor">
+<Project Sdk="Microsoft.NET.Sdk.Razor">
 
   <PropertyGroup>
     <TargetFramework>net9.0</TargetFramework>
@@ -15,7 +15,7 @@
 
   <ItemGroup>
     <ProjectReference Include="..\Elastic.Documentation\Elastic.Documentation.csproj" />
-    <ProjectReference Include="..\Elastic.Documentation.Configuration\Elastic.Documentation.Configuration.csproj" />
+        <ProjectReference Include="..\Elastic.Documentation.Configuration\Elastic.Documentation.Configuration.csproj" />
   </ItemGroup>
 
   <ItemGroup>

src/Elastic.Markdown/IO/Navigation/ExternalLinkNavigationItem.cs renamed to src/Elastic.Documentation.Site/Navigation/ExternalLinkNavigationItem.cs

@@ -4,17 +4,17 @@
 
 using Elastic.Documentation.Site.Navigation;
 
-namespace Elastic.Markdown.IO.Navigation;
+namespace Elastic.Documentation.Site.Navigation;
 
 /// <summary>
 /// Navigation item representing an external URL in the TOC.
 /// </summary>
-public record ExternalLinkNavigationItem(string ExternalUrl, string Title, DocumentationGroup Group)
+public record ExternalLinkNavigationItem(string ExternalUrl, string Title, INodeNavigationItem<INavigationModel, INavigationItem> Parent, IRootNavigationItem<INavigationModel, INavigationItem> NavigationRoot)
 	: INavigationItem
 {
-	public INodeNavigationItem<INavigationModel, INavigationItem>? Parent { get; set; } = Group;
+	public INodeNavigationItem<INavigationModel, INavigationItem>? Parent { get; set; } = Parent;
 
-	public IRootNavigationItem<INavigationModel, INavigationItem> NavigationRoot { get; } = Group.NavigationRoot;
+	public IRootNavigationItem<INavigationModel, INavigationItem> NavigationRoot { get; } = NavigationRoot;
 
 	public string Url => ExternalUrl;
 

src/Elastic.Documentation.Site/Navigation/_TocTreeNav.cshtml

@@ -1,4 +1,5 @@
 @using Elastic.Documentation.Site.Navigation
+
 @inherits RazorSlice<NavigationTreeItem>
 @{
 	var isTopLevel = Model.Level == 0;
@@ -89,4 +90,18 @@
 			</a>
 		</li>
 	}
+	else if (item is ExternalLinkNavigationItem ext)
+	{
+		<li class="flex group/li pr-8 @(isTopLevel ? "font-semibold mt-6" : "mt-4")">
+			<a
+				href="@ext.Url"
+				target="_blank"
+				rel="noopener noreferrer"
+				class="sidebar-link grow group-[.current]/li:text-blue-elastic! flex items-center"
+			>
+				@ext.NavigationTitle
+				<svg class="ml-1 inline w-4 h-4 text-grey-60" xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 24 24" stroke="currentColor"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M14 3h7v7m0 0L10 21l-7-7 11-11z"/></svg>
+			</a>
+		</li>
+	}
 }

src/Elastic.Markdown/IO/DocumentationSet.cs

@@ -19,6 +19,7 @@
 using Elastic.Markdown.Links.CrossLinks;
 using Elastic.Markdown.Myst;
 using Microsoft.Extensions.Logging;
+using ExternalLinkNavigationItem = Elastic.Documentation.Site.Navigation.ExternalLinkNavigationItem;
 
 namespace Elastic.Markdown.IO;
 
@@ -227,6 +228,10 @@ private void UpdateNavigationIndex(IReadOnlyCollection<INavigationItem> navigati
 					documentationGroup.NavigationIndex = groupIndex;
 					UpdateNavigationIndex(documentationGroup.NavigationItems, ref navigationIndex);
 					break;
+				case ExternalLinkNavigationItem ext:
+					var linkIndex = Interlocked.Increment(ref navigationIndex);
+					ext.NavigationIndex = linkIndex;
+					break;
 				default:
 					Context.EmitError(Context.ConfigurationPath, $"Unhandled navigation item type: {item.GetType()}");
 					break;

src/Elastic.Markdown/IO/Navigation/DocumentationGroup.cs

@@ -6,9 +6,9 @@
 using Elastic.Documentation;
 using Elastic.Documentation.Configuration;
 using Elastic.Documentation.Configuration.TableOfContents;
-using Elastic.Markdown.IO.Navigation; // for ExternalLinkNavigationItem
 using Elastic.Documentation.Extensions;
 using Elastic.Documentation.Site.Navigation;
+using ExternalLinkNavigationItem = Elastic.Documentation.Site.Navigation.ExternalLinkNavigationItem;
 
 namespace Elastic.Markdown.IO.Navigation;
 
@@ -181,7 +181,7 @@ void AddToNavigationItems(INavigationItem item, ref int fileIndex)
 			}
 			else if (tocItem is LinkReference extLink)
 			{
-				var nav = new ExternalLinkNavigationItem(extLink.Url, extLink.Title, this);
+				var nav = new ExternalLinkNavigationItem(extLink.Url, extLink.Title, this, rootNavigationItem);
 				AddToNavigationItems(nav, ref fileIndex);
 			}
 			else if (tocItem is FolderReference folder)

src/tooling/docs-assembler/Building/SitemapBuilder.cs

@@ -76,6 +76,9 @@ private static IReadOnlyCollection<INavigationItem> GetNavigationItems(IReadOnly
 					result.AddRange(GetNavigationItems(group.NavigationItems));
 					result.Add(group);
 					break;
+				case ExternalLinkNavigationItem link:
+					// skip external links in sitemap
+					continue;
 				default:
 					throw new Exception($"Unhandled navigation item type: {item.GetType()}");
 			}

src/tooling/docs-assembler/Navigation/GlobalNavigation.cs

@@ -82,6 +82,11 @@ private void UpdateParent(
 					_ = allNavigationItems.Add(documentationGroup);
 					UpdateParent(allNavigationItems, documentationGroup.NavigationItems, documentationGroup);
 					break;
+				case ExternalLinkNavigationItem extLink:
+					if (parent is not null)
+						extLink.Parent = parent;
+					_ = allNavigationItems.Add(extLink);
+					break;
 				default:
 					_navigationFile.EmitError($"Unhandled navigation item type: {item.GetType()}");
 					break;
@@ -105,6 +110,10 @@ private void UpdateNavigationIndex(IReadOnlyCollection<INavigationItem> navigati
 					documentationGroup.NavigationIndex = groupIndex;
 					UpdateNavigationIndex(documentationGroup.NavigationItems, ref navigationIndex);
 					break;
+				case ExternalLinkNavigationItem extLink:
+					var linkIndex = Interlocked.Increment(ref navigationIndex);
+					extLink.NavigationIndex = linkIndex;
+					break;
 				default:
 					_navigationFile.EmitError($"Unhandled navigation item type: {item.GetType()}");
 					break;