Skip to content

Commit 9d411d0

Browse files
committed
Make PublishEnvironment optional
1 parent 18b5135 commit 9d411d0

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

src/tooling/Elastic.Documentation.Tooling/Arguments/ExportOption.cs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,9 @@ public static class ExporterExtensions
6060

6161
public static IReadOnlyCollection<IMarkdownExporter> CreateMarkdownExporters(
6262
this IReadOnlySet<Exporter> exportOptions,
63-
PublishEnvironment environment,
6463
ILoggerFactory logFactory,
65-
IDocumentationConfigurationContext context
64+
IDocumentationConfigurationContext context,
65+
PublishEnvironment? environment = null
6666
)
6767
{
6868
var markdownExporters = new List<IMarkdownExporter>(3);
@@ -73,7 +73,11 @@ IDocumentationConfigurationContext context
7373
if (exportOptions.Contains(Elasticsearch))
7474
markdownExporters.Add(new ElasticsearchMarkdownExporter(logFactory, context.Collector, context.Endpoints));
7575
if (exportOptions.Contains(SemanticElasticsearch))
76+
{
77+
if (environment is null)
78+
throw new ArgumentNullException(nameof(environment), "A publish environment is required when using the semantic elasticsearch exporter");
7679
markdownExporters.Add(new ElasticsearchMarkdownSemanticExporter(environment, logFactory, context.Collector, context.Endpoints));
80+
}
7781
return markdownExporters;
7882
}
7983
}

src/tooling/docs-assembler/Building/AssemblerBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public async Task BuildAllAsync(PublishEnvironment environment, FrozenDictionary
4141

4242
var redirects = new Dictionary<string, string>();
4343

44-
var markdownExporters = exportOptions.CreateMarkdownExporters(environment, logFactory, context);
44+
var markdownExporters = exportOptions.CreateMarkdownExporters(logFactory, context, environment);
4545

4646
var tasks = markdownExporters.Select(async e => await e.StartAsync(ctx));
4747
await Task.WhenAll(tasks);

0 commit comments

Comments
 (0)