Skip to content

Commit b78c2c3

Browse files
committed
Add title validation
1 parent d4bd6ca commit b78c2c3

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

src/Elastic.Documentation.Configuration/Builder/TableOfContentsConfiguration.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,6 @@ private IReadOnlyCollection<ITocItem> ReadChildren(YamlStreamReader reader, KeyV
210210

211211
if (crossLink is not null)
212212
{
213-
// No validation here - we'll validate cross-links separately
214213
return [new CrossLinkReference(this, crossLink, title, hiddenFile, children ?? [])];
215214
}
216215

src/Elastic.Markdown/IO/Navigation/DocumentationGroup.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,12 @@ void AddToNavigationItems(INavigationItem item, ref int fileIndex)
121121
{
122122
if (tocItem is CrossLinkReference crossLink)
123123
{
124+
if (string.IsNullOrWhiteSpace(crossLink.Title))
125+
{
126+
context.EmitError(context.ConfigurationPath,
127+
$"Cross-link entries must have a 'title' specified. Cross-link: {crossLink.CrossLinkUri}");
128+
continue;
129+
}
124130
// Create a special navigation item for cross-repository links
125131
var crossLinkItem = new CrossLinkNavigationItem(crossLink.CrossLinkUri, crossLink.Title, this, crossLink.Hidden);
126132
AddToNavigationItems(crossLinkItem, ref fileIndex);

0 commit comments

Comments
 (0)