Fix tests expecting crosslink navigation item

Author: Mpdreamz

tests/Navigation.Tests/Isolation/ConstructorTests.cs

@@ -127,7 +127,7 @@ public void ConstructorCreatesCrossLinkNavigation()
 		var context = CreateContext(fileSystem);
 		var docSet = DocumentationSetFile.LoadAndResolve(context.Collector, yaml, fileSystem.NewDirInfo("docs"));
 
-		var navigation = new DocumentationSetNavigation<IDocumentationFile>(docSet, context, GenericDocumentationFileFactory.Instance);
+		var navigation = new DocumentationSetNavigation<IDocumentationFile>(docSet, context, GenericDocumentationFileFactory.Instance, crossLinkResolver: TestCrossLinkResolver.Instance);
 
 		navigation.NavigationItems.Should().HaveCount(0);
 		var crossLink = navigation.Index.Should().BeOfType<CrossLinkNavigationLeaf>().Subject;

tests/Navigation.Tests/Isolation/NavigationStructureTests.cs

@@ -151,7 +151,7 @@ public async Task ComplexNestedStructureBuildsCorrectly()
 		var docSet = DocumentationSetFile.LoadAndResolve(context.Collector, yaml, fileSystem.NewDirInfo("docs"));
 		_ = context.Collector.StartAsync(TestContext.Current.CancellationToken);
 
-		var navigation = new DocumentationSetNavigation<TestDocumentationFile>(docSet, context, TestDocumentationFileFactory.Instance);
+		var navigation = new DocumentationSetNavigation<TestDocumentationFile>(docSet, context, TestDocumentationFileFactory.Instance, crossLinkResolver: TestCrossLinkResolver.Instance);
 
 		await context.Collector.StopAsync(TestContext.Current.CancellationToken);
 
@@ -295,7 +295,7 @@ public void AllNavigationItemsHaveNavigationRootSet()
 		var context = CreateContext(fileSystem);
 		var docSet = DocumentationSetFile.LoadAndResolve(context.Collector, yaml, fileSystem.NewDirInfo("docs"));
 
-		var navigation = new DocumentationSetNavigation<TestDocumentationFile>(docSet, context, TestDocumentationFileFactory.Instance);
+		var navigation = new DocumentationSetNavigation<TestDocumentationFile>(docSet, context, TestDocumentationFileFactory.Instance, crossLinkResolver: TestCrossLinkResolver.Instance);
 
 		// Helper to recursively visit all navigation items
 		var allItems = new List<INavigationItem>();

tests/Navigation.Tests/Isolation/PhysicalDocsetTests.cs

@@ -6,7 +6,6 @@
 using Elastic.Documentation.Configuration;
 using Elastic.Documentation.Configuration.DocSet;
 using Elastic.Documentation.Diagnostics;
-using Elastic.Documentation.Navigation.Isolated;
 using Elastic.Documentation.Navigation.Isolated.Leaf;
 using Elastic.Documentation.Navigation.Isolated.Node;
 using FluentAssertions;
@@ -30,7 +29,7 @@ public async Task PhysicalDocsetCanBeNavigated()
 		var docSet = DocumentationSetFile.LoadAndResolve(context.Collector, configPath, fileSystem);
 		_ = context.Collector.StartAsync(TestContext.Current.CancellationToken);
 
-		var navigation = new DocumentationSetNavigation<TestDocumentationFile>(docSet, context, TestDocumentationFileFactory.Instance);
+		var navigation = new DocumentationSetNavigation<TestDocumentationFile>(docSet, context, TestDocumentationFileFactory.Instance, crossLinkResolver: TestCrossLinkResolver.Instance);
 
 		await context.Collector.StopAsync(TestContext.Current.CancellationToken);
 
@@ -171,7 +170,7 @@ public async Task PhysicalDocsetNavigationHandlesCrossLinks()
 		var docSet = DocumentationSetFile.LoadAndResolve(context.Collector, configPath);
 		_ = context.Collector.StartAsync(TestContext.Current.CancellationToken);
 
-		var navigation = new DocumentationSetNavigation<TestDocumentationFile>(docSet, context, TestDocumentationFileFactory.Instance);
+		var navigation = new DocumentationSetNavigation<TestDocumentationFile>(docSet, context, TestDocumentationFileFactory.Instance, crossLinkResolver: TestCrossLinkResolver.Instance);
 
 		await context.Collector.StopAsync(TestContext.Current.CancellationToken);
 

tests/Navigation.Tests/TestDocumentationSetContext.cs

@@ -2,10 +2,12 @@
 // Elasticsearch B.V licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information
 
+using System.Diagnostics.CodeAnalysis;
 using System.IO.Abstractions;
 using Elastic.Documentation;
 using Elastic.Documentation.Diagnostics;
 using Elastic.Documentation.Extensions;
+using Elastic.Documentation.Links.CrossLinks;
 using Elastic.Documentation.Navigation.Isolated;
 using Markdig;
 using Markdig.Parsers;
@@ -46,6 +48,25 @@ public override void Write(Diagnostic diagnostic)
 	public override Task StopAsync(Cancel cancellationToken) => Task.CompletedTask;
 }
 
+/// <summary>A cross link resolver that always resolves to a fixed URL </summary>
+public class TestCrossLinkResolver : ICrossLinkResolver
+{
+	public static TestCrossLinkResolver Instance { get; } = new();
+
+	/// <inheritdoc />
+	public bool TryResolve(Action<string> errorEmitter, Uri crossLinkUri, [NotNullWhen(true)] out Uri? resolvedUri)
+	{
+		resolvedUri = new Uri("https://docs-v3-preview.elastic.dev/elastic/docs-builder/tree/main");
+		return true;
+	}
+
+	/// <inheritdoc />
+	public IUriEnvironmentResolver UriResolver { get; } = new IsolatedBuildEnvironmentUriResolver();
+
+	private TestCrossLinkResolver() { }
+
+}
+
 public class TestDocumentationSetContext : IDocumentationSetContext
 {
 	public TestDocumentationSetContext(IFileSystem fileSystem,