Peer edits

Author: theletterf

src/Elastic.Markdown/Myst/InlineParsers/Substitution/SubstitutionMutationHelper.cs

@@ -29,6 +29,22 @@ public static (string Key, string[] Mutations) ParseKeyWithMutations(string rawK
 		return (key, mutations);
 	}
 
+	/// <summary>
+	/// Applies mutations to a value using the existing SubstitutionMutation system
+	/// </summary>
+	/// <param name="value">The original value to transform</param>
+	/// <param name="mutations">Collection of SubstitutionMutation enums to apply</param>
+	/// <returns>The transformed value</returns>
+	public static string ApplyMutations(string value, IReadOnlyCollection<SubstitutionMutation> mutations)
+	{
+		var result = value;
+		foreach (var mutation in mutations)
+		{
+			result = ApplySingleMutation(result, mutation);
+		}
+		return result;
+	}
+
 	/// <summary>
 	/// Applies mutations to a value using the existing SubstitutionMutation system
 	/// </summary>
@@ -43,34 +59,41 @@ public static string ApplyMutations(string value, string[] mutations)
 			var trimmedMutation = mutationStr.Trim();
 			if (SubstitutionMutationExtensions.TryParse(trimmedMutation, out var mutation, true, true))
 			{
-				// Use the same logic as SubstitutionRenderer.Write
-				var (success, update) = mutation switch
-				{
-					SubstitutionMutation.MajorComponent => TryGetVersion(result, v => $"{v.Major}"),
-					SubstitutionMutation.MajorX => TryGetVersion(result, v => $"{v.Major}.x"),
-					SubstitutionMutation.MajorMinor => TryGetVersion(result, v => $"{v.Major}.{v.Minor}"),
-					SubstitutionMutation.IncreaseMajor => TryGetVersion(result, v => $"{v.Major + 1}.0.0"),
-					SubstitutionMutation.IncreaseMinor => TryGetVersion(result, v => $"{v.Major}.{v.Minor + 1}.0"),
-					SubstitutionMutation.LowerCase => (true, result.ToLowerInvariant()),
-					SubstitutionMutation.UpperCase => (true, result.ToUpperInvariant()),
-					SubstitutionMutation.Capitalize => (true, Capitalize(result)),
-					SubstitutionMutation.KebabCase => (true, ToKebabCase(result)),
-					SubstitutionMutation.CamelCase => (true, ToCamelCase(result)),
-					SubstitutionMutation.PascalCase => (true, ToPascalCase(result)),
-					SubstitutionMutation.SnakeCase => (true, ToSnakeCase(result)),
-					SubstitutionMutation.TitleCase => (true, TitleCase(result)),
-					SubstitutionMutation.Trim => (true, Trim(result)),
-					_ => (false, result)
-				};
-				if (success)
-				{
-					result = update;
-				}
+				result = ApplySingleMutation(result, mutation);
 			}
 		}
 		return result;
 	}
 
+	/// <summary>
+	/// Applies a single mutation to a value
+	/// </summary>
+	/// <param name="value">The value to transform</param>
+	/// <param name="mutation">The mutation to apply</param>
+	/// <returns>The transformed value</returns>
+	private static string ApplySingleMutation(string value, SubstitutionMutation mutation)
+	{
+		var (success, result) = mutation switch
+		{
+			SubstitutionMutation.MajorComponent => TryGetVersion(value, v => $"{v.Major}"),
+			SubstitutionMutation.MajorX => TryGetVersion(value, v => $"{v.Major}.x"),
+			SubstitutionMutation.MajorMinor => TryGetVersion(value, v => $"{v.Major}.{v.Minor}"),
+			SubstitutionMutation.IncreaseMajor => TryGetVersion(value, v => $"{v.Major + 1}.0.0"),
+			SubstitutionMutation.IncreaseMinor => TryGetVersion(value, v => $"{v.Major}.{v.Minor + 1}.0"),
+			SubstitutionMutation.LowerCase => (true, value.ToLowerInvariant()),
+			SubstitutionMutation.UpperCase => (true, value.ToUpperInvariant()),
+			SubstitutionMutation.Capitalize => (true, Capitalize(value)),
+			SubstitutionMutation.KebabCase => (true, ToKebabCase(value)),
+			SubstitutionMutation.CamelCase => (true, ToCamelCase(value)),
+			SubstitutionMutation.PascalCase => (true, ToPascalCase(value)),
+			SubstitutionMutation.SnakeCase => (true, ToSnakeCase(value)),
+			SubstitutionMutation.TitleCase => (true, TitleCase(value)),
+			SubstitutionMutation.Trim => (true, Trim(value)),
+			_ => (false, value)
+		};
+		return success ? result : value;
+	}
+
 	private static (bool Success, string Result) TryGetVersion(string version, Func<SemVersion, string> transform)
 	{
 		if (!SemVersion.TryParse(version, out var v) && !SemVersion.TryParse(version + ".0", out v))

src/Elastic.Markdown/Myst/InlineParsers/Substitution/SubstitutionParser.cs

@@ -67,8 +67,7 @@ protected override void Write(HtmlRenderer renderer, SubstitutionLeaf leaf)
 		}
 
 		// Apply mutations using shared utility
-		var mutationStrings = leaf.Mutations.Select(m => m.ToStringFast(true)).ToArray();
-		replacement = SubstitutionMutationHelper.ApplyMutations(replacement, mutationStrings);
+		replacement = SubstitutionMutationHelper.ApplyMutations(replacement, leaf.Mutations);
 		_ = renderer.Write(replacement);
 	}
 }