Emit error for empty crosslink text (#1954)

* Initial plan

* Implement crosslink empty text auto-title feature

Co-authored-by: reakaleek <[email protected]>

* Add comprehensive tests for crosslink empty text feature

Co-authored-by: reakaleek <[email protected]>

* Change empty crosslink text behavior to emit error when no title available

Co-authored-by: Mpdreamz <[email protected]>

* Remove Title property from LinkMetadata and TryGetLinkMetadata method

Co-authored-by: Mpdreamz <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: reakaleek <[email protected]>
Co-authored-by: Jan Calanog <[email protected]>
Co-authored-by: Mpdreamz <[email protected]>
Co-authored-by: Martijn Laarman <[email protected]>

Author: 3 people

src/Elastic.Markdown/Myst/InlineParsers/DiagnosticLinkInlineParser.cs

@@ -184,6 +184,12 @@ private static void ProcessCrossLink(LinkInline link, InlineProcessor processor,
 				uri, out var resolvedUri)
 			 )
 			link.Url = resolvedUri.ToString();
+
+		// Emit error for empty link text in crosslinks
+		if (link.FirstChild == null)
+		{
+			processor.EmitError(link, $"Crosslink '{url}' has empty link text. Please provide explicit link text.");
+		}
 	}
 
 	private static void ProcessInternalLink(LinkInline link, InlineProcessor processor, ParserContext context)

tests/Elastic.Markdown.Tests/Inline/InlineLinkTests.cs

@@ -164,6 +164,62 @@ public void EmitsCrossLink()
 	}
 }
 
+public class CrossLinkEmptyTextTest(ITestOutputHelper output) : LinkTestBase(output,
+	"""
+
+	Go to [](kibana://index.md)
+	"""
+)
+{
+	[Fact]
+	public void GeneratesHtml() =>
+		// language=html - empty crosslinks now emit an error
+		Html.Should().Contain(
+			"""<p>Go to <a href="https://docs-v3-preview.elastic.dev/elastic/kibana/tree/main/" hx-select-oob="#main-container" preload="mousedown"></a></p>"""
+		);
+
+	[Fact]
+	public void HasError() =>
+		Collector.Diagnostics.Should().Contain(d =>
+			d.Severity == Severity.Error &&
+			d.Message.Contains("empty link text"));
+
+	[Fact]
+	public void EmitsCrossLink()
+	{
+		Collector.CrossLinks.Should().HaveCount(1);
+		Collector.CrossLinks.Should().Contain("kibana://index.md");
+	}
+}
+
+public class CrossLinkEmptyTextNoTitleTest(ITestOutputHelper output) : LinkTestBase(output,
+	"""
+
+	Go to [](kibana://get-started/index.md)
+	"""
+)
+{
+	[Fact]
+	public void GeneratesHtml() =>
+		// language=html - empty crosslinks emit an error
+		Html.Should().Contain(
+			"""<p>Go to <a href="https://docs-v3-preview.elastic.dev/elastic/kibana/tree/main/get-started" hx-select-oob="#main-container" preload="mousedown"></a></p>"""
+		);
+
+	[Fact]
+	public void HasError() =>
+		Collector.Diagnostics.Should().Contain(d =>
+			d.Severity == Severity.Error &&
+			d.Message.Contains("empty link text"));
+
+	[Fact]
+	public void EmitsCrossLink()
+	{
+		Collector.CrossLinks.Should().HaveCount(1);
+		Collector.CrossLinks.Should().Contain("kibana://get-started/index.md");
+	}
+}
+
 public class LinkWithUnresolvedInterpolationError(ITestOutputHelper output) : LinkTestBase(output,
 	"""
 	[global search field]({{this-variable-does-not-exist}}/introduction.html#kibana-navigation-search)

tests/authoring/Framework/TestCrossLinkResolver.fs

@@ -90,3 +90,4 @@ type TestCrossLinkResolver (config: ConfigurationFile) =
             CrossLinkResolver.TryResolve(errorEmitter, crossLinks, uriResolver, crossLinkUri, &resolvedUri)
 
 
+