Rename to CrossLinks

Author: reakaleek

docs/source/docset.yml

@@ -77,4 +77,4 @@ toc:
       - file: index.md
       - file: req.md
       - folder: nested
-      - file: external-links.md
+      - file: cross-links.md

docs/source/testing/external-links.md renamed to docs/source/testing/cross-links.md

@@ -1,5 +1,5 @@
 ---
-title: External Links
+title: Cross Links
 ---
 
 [Elasticsearch](elasticsearch://index.md)

src/Elastic.Markdown/Diagnostics/DiagnosticsChannel.cs

@@ -87,7 +87,7 @@ public class DiagnosticsCollector(ILoggerFactory loggerFactory, IReadOnlyCollect
 
 	public HashSet<string> OffendingFiles { get; } = new();
 
-	public ConcurrentDictionary<string, bool> ExternalLinks { get; } = new();
+	public ConcurrentDictionary<string, bool> CrossLinks { get; } = new();
 
 	public Task StartAsync(Cancel ctx)
 	{
@@ -143,7 +143,7 @@ public virtual async Task StopAsync(CancellationToken cancellationToken)
 		await Channel.Reader.Completion;
 	}
 
-	public void EmitExternalLink(string link) => ExternalLinks.TryAdd(link, true);
+	public void EmitExternalLink(string link) => CrossLinks.TryAdd(link, true);
 
 	public void EmitError(string file, string message, Exception? e = null)
 	{

src/Elastic.Markdown/IO/LinkReference.cs

@@ -17,12 +17,12 @@ public record LinkReference
 	[JsonPropertyName("links")]
 	public required string[] Links { get; init; } = [];
 
-	[JsonPropertyName("external_links")]
-	public required string[] ExternalLinks { get; init; } = [];
+	[JsonPropertyName("cross_links")]
+	public required string[] CrossLinks { get; init; } = [];
 
 	public static LinkReference Create(DocumentationSet set)
 	{
-		var externalLinks = set.Context.Collector.ExternalLinks.Select(i => i.Key).ToArray();
+		var crossLinks = set.Context.Collector.CrossLinks.Select(i => i.Key).ToArray();
 
 		var links = set.FlatMappedFiles.Values
 			.OfType<MarkdownFile>()
@@ -32,7 +32,7 @@ public static LinkReference Create(DocumentationSet set)
 			UrlPathPrefix = set.Context.UrlPathPrefix,
 			Origin = set.Context.Git,
 			Links = links,
-			ExternalLinks = externalLinks
+			CrossLinks = crossLinks
 		};
 	}
 }

tests/Elastic.Markdown.Tests/Inline/InlineLinkTests.cs

@@ -103,7 +103,7 @@ public void GeneratesHtml() =>
 	public void HasNoErrors() => Collector.Diagnostics.Should().HaveCount(0);
 }
 
-public class ExternalLinkReferenceTest(ITestOutputHelper output) : LinkTestBase(output,
+public class CrossLinkReferenceTest(ITestOutputHelper output) : LinkTestBase(output,
 	"""
 	[test][test]
 
@@ -123,14 +123,14 @@ public void GeneratesHtml() =>
 	public void HasNoErrors() => Collector.Diagnostics.Should().HaveCount(0);
 
 	[Fact]
-	public void EmitsExternalLink()
+	public void EmitsCrossLink()
 	{
-		Collector.ExternalLinks.Should().HaveCount(1);
-		Collector.ExternalLinks.Should().ContainKey("kibana://index.md");
+		Collector.CrossLinks.Should().HaveCount(1);
+		Collector.CrossLinks.Should().ContainKey("kibana://index.md");
 	}
 }
 
-public class ExternalLinkTest(ITestOutputHelper output) : LinkTestBase(output,
+public class CrossLinkTest(ITestOutputHelper output) : LinkTestBase(output,
 	"""
 	[test](kibana://index.md)
 	"""
@@ -148,14 +148,14 @@ public void GeneratesHtml() =>
 	public void HasNoErrors() => Collector.Diagnostics.Should().HaveCount(0);
 
 	[Fact]
-	public void EmitsExternalLink()
+	public void EmitsCrossLink()
 	{
-		Collector.ExternalLinks.Should().HaveCount(1);
-		Collector.ExternalLinks.Should().ContainKey("kibana://index.md");
+		Collector.CrossLinks.Should().HaveCount(1);
+		Collector.CrossLinks.Should().ContainKey("kibana://index.md");
 	}
 }
 
-public class DuplicateExternalLinkTest(ITestOutputHelper output) : LinkTestBase(output,
+public class DuplicateCrossLinkTest(ITestOutputHelper output) : LinkTestBase(output,
 	"""
 	[a](kibana://index.md)
 	[b](kibana://index.md)
@@ -179,11 +179,11 @@ public void GeneratesHtml() =>
 	public void HasNoErrors() => Collector.Diagnostics.Should().HaveCount(0);
 
 	[Fact]
-	public void EmitsExternalLink()
+	public void EmitsCrossLink()
 	{
-		Collector.ExternalLinks.Should().HaveCount(2);
-		Collector.ExternalLinks.Should().ContainKey("kibana://index.md");
-		Collector.ExternalLinks.Should().ContainKey("elasticsearch://index.md");
+		Collector.CrossLinks.Should().HaveCount(2);
+		Collector.CrossLinks.Should().ContainKey("kibana://index.md");
+		Collector.CrossLinks.Should().ContainKey("elasticsearch://index.md");
 	}
 }