Skip to content

Commit e15f0fd

Browse files
committed
ignore hidden for DetectionRuleFile
1 parent 89a07c3 commit e15f0fd

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

src/Elastic.Markdown/IO/Navigation/FileNavigationItem.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
namespace Elastic.Markdown.IO.Navigation;
99

1010
[DebuggerDisplay("Current: {Model.RelativePath}")]
11-
public record FileNavigationItem(MarkdownFile Model, DocumentationGroup Group, bool Hidden = false) : ILeafNavigationItem<MarkdownFile>
11+
public record FileNavigationItem(MarkdownFile Model, DocumentationGroup Group, bool Hidden = false)
12+
: ILeafNavigationItem<MarkdownFile>
1213
{
1314
public INodeNavigationItem<INavigationModel, INavigationItem>? Parent { get; set; } = Group;
1415
public IRootNavigationItem<INavigationModel, INavigationItem> NavigationRoot { get; } = Group.NavigationRoot;

src/tooling/docs-assembler/Building/SitemapBuilder.cs

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
using System.IO.Abstractions;
66
using System.Xml.Linq;
77
using Elastic.Documentation.Site.Navigation;
8+
using Elastic.Markdown.Extensions.DetectionRules;
89
using Elastic.Markdown.IO.Navigation;
910

1011
namespace Documentation.Assembler.Building;
@@ -59,15 +60,19 @@ private static IReadOnlyCollection<INavigationItem> GetNavigationItems(IReadOnly
5960
var result = new List<INavigationItem>();
6061
foreach (var item in items)
6162
{
62-
if (item.Hidden)
63-
continue;
64-
6563
switch (item)
6664
{
6765
case FileNavigationItem file:
66+
// these are hidden from the navigation programatically.
67+
// TODO find a cleaner way to model this.
68+
if (item.Hidden && file.Model is not DetectionRuleFile)
69+
continue;
6870
result.Add(file);
6971
break;
7072
case DocumentationGroup group:
73+
if (item.Hidden)
74+
continue;
75+
7176
result.AddRange(GetNavigationItems(group.NavigationItems));
7277
result.Add(group);
7378
break;

0 commit comments

Comments
 (0)