fix tests compilation

Author: Mpdreamz

src/tooling/docs-assembler/Deploying/AwsS3SyncPlanStrategy.cs

@@ -82,8 +82,6 @@ public class AwsS3SyncPlanStrategy(
 )
 	: IDocsSyncPlanStrategy
 {
-	private readonly ILogger<AwsS3SyncPlanStrategy> _logger = logFactory.CreateLogger<AwsS3SyncPlanStrategy>();
-
 	private readonly IS3EtagCalculator _s3EtagCalculator = calculator ?? new S3EtagCalculator(logFactory, context.ReadFileSystem);
 
 	private bool IsSymlink(string path)
@@ -92,7 +90,7 @@ private bool IsSymlink(string path)
 		return fileInfo.LinkTarget != null;
 	}
 
-	public async Task<SyncPlan> Plan(float? deleteThreshold = null, Cancel ctx = default)
+	public async Task<SyncPlan> Plan(float? deleteThreshold, Cancel ctx = default)
 	{
 		var remoteObjects = await ListObjects(ctx);
 		var localObjects = context.OutputDirectory.GetFiles("*", SearchOption.AllDirectories)

src/tooling/docs-assembler/Deploying/DocsSync.cs

@@ -9,7 +9,7 @@ namespace Documentation.Assembler.Deploying;
 
 public interface IDocsSyncPlanStrategy
 {
-	Task<SyncPlan> Plan(float? deleteThreshold = null, Cancel ctx = default);
+	Task<SyncPlan> Plan(float? deleteThreshold, Cancel ctx = default);
 
 }
 public record PlanValidationResult(bool Valid, float DeleteRatio, float DeleteThreshold);

tests/docs-assembler.Tests/src/docs-assembler.Tests/DocsSyncTests.cs

@@ -10,6 +10,7 @@
 using Elastic.Documentation.Configuration;
 using Elastic.Documentation.Configuration.Assembler;
 using Elastic.Documentation.Diagnostics;
+using Elastic.Documentation.Tooling.Diagnostics;
 using FakeItEasy;
 using FluentAssertions;
 using Microsoft.Extensions.Logging;
@@ -62,7 +63,7 @@ public async Task TestPlan()
 		var planStrategy = new AwsS3SyncPlanStrategy(new LoggerFactory(), mockS3Client, "fake", context);
 
 		// Act
-		var plan = await planStrategy.Plan(ctx: Cancel.None);
+		var plan = await planStrategy.Plan(null, Cancel.None);
 
 		// Assert
 
@@ -108,7 +109,7 @@ public async Task ValidateAdditionsPlan(
 		bool valid
 	)
 	{
-		var (planStrategy, plan) = await SetupS3SyncContextSetup(localFiles, remoteFiles);
+		var (validator, _, plan) = await SetupS3SyncContextSetup(localFiles, remoteFiles, deleteThreshold);
 
 		// Assert
 
@@ -118,7 +119,7 @@ bool valid
 		plan.AddRequests.Count.Should().Be(totalFilesToAdd);
 		plan.DeleteRequests.Count.Should().Be(totalFilesToRemove);
 
-		var validationResult = planStrategy.Validate(plan, deleteThreshold);
+		var validationResult = validator.Validate(plan);
 		if (plan.TotalSyncRequests <= 100)
 			validationResult.DeleteThreshold.Should().Be(Math.Max(deleteThreshold, 0.8f));
 		else if (plan.TotalSyncRequests <= 1000)
@@ -146,7 +147,7 @@ public async Task ValidateUpdatesPlan(
 		bool valid
 	)
 	{
-		var (planStrategy, plan) = await SetupS3SyncContextSetup(localFiles, remoteFiles, "different-etag");
+		var (validator, _, plan) = await SetupS3SyncContextSetup(localFiles, remoteFiles, deleteThreshold, "different-etag");
 
 		// Assert
 
@@ -156,7 +157,7 @@ bool valid
 		plan.UpdateRequests.Count.Should().Be(totalFilesToUpdate);
 		plan.DeleteRequests.Count.Should().Be(totalFilesToRemove);
 
-		var validationResult = planStrategy.Validate(plan, deleteThreshold);
+		var validationResult = validator.Validate(plan);
 		if (plan.TotalSyncRequests <= 100)
 			validationResult.DeleteThreshold.Should().Be(Math.Max(deleteThreshold, 0.8f));
 		else if (plan.TotalSyncRequests <= 1000)
@@ -165,8 +166,8 @@ bool valid
 		validationResult.Valid.Should().Be(valid, $"Delete ratio is {validationResult.DeleteRatio} when maximum is {validationResult.DeleteThreshold}");
 	}
 
-	private static async Task<(AwsS3SyncPlanStrategy planStrategy, SyncPlan plan)> SetupS3SyncContextSetup(
-		int localFiles, int remoteFiles, string etag = "etag")
+	private static async Task<(DocsSyncPlanValidator validator, AwsS3SyncPlanStrategy planStrategy, SyncPlan plan)> SetupS3SyncContextSetup(
+		int localFiles, int remoteFiles, float? deleteThreshold = null, string etag = "etag")
 	{
 		// Arrange
 		IReadOnlyCollection<IDiagnosticsOutput> diagnosticsOutputs = [];
@@ -204,8 +205,9 @@ bool valid
 		var planStrategy = new AwsS3SyncPlanStrategy(new LoggerFactory(), mockS3Client, "fake", context, mockEtagCalculator);
 
 		// Act
-		var plan = await planStrategy.Plan(ctx: Cancel.None);
-		return (planStrategy, plan);
+		var plan = await planStrategy.Plan(deleteThreshold, Cancel.None);
+		var validator = new DocsSyncPlanValidator(new LoggerFactory());
+		return (validator, planStrategy, plan);
 	}
 
 	[Fact]
@@ -233,6 +235,7 @@ public async Task TestApply()
 		var context = new AssembleContext(config, configurationContext, "dev", collector, fileSystem, fileSystem, null, checkoutDirectory);
 		var plan = new SyncPlan
 		{
+			DeleteThresholdDefault = null,
 			TotalRemoteFiles = 0,
 			TotalSourceFiles = 5,
 			TotalSyncRequests = 6,