ExceptionFilter should only explicitly set exit code in catch not finally (#1937)

Author: Mpdreamz

src/tooling/Elastic.Documentation.Tooling/Filters/CatchExceptionFilter.cs

@@ -20,7 +20,6 @@ public override async Task InvokeAsync(ConsoleAppContext context, Cancel cancell
 			logger.LogInformation("Received CTRL+C cancelling");
 			_cancelKeyPressed = true;
 		};
-		var error = false;
 		try
 		{
 			await Next.InvokeAsync(context, cancellationToken);
@@ -32,14 +31,10 @@ public override async Task InvokeAsync(ConsoleAppContext context, Cancel cancell
 				logger.LogInformation("Cancellation requested, exiting.");
 				return;
 			}
-			error = true;
 			_ = collector.StartAsync(cancellationToken);
 			collector.EmitGlobalError($"Global unhandled exception: {ex.Message}", ex);
 			await collector.StopAsync(cancellationToken);
-		}
-		finally
-		{
-			Environment.ExitCode = error ? 1 : 0;
+			Environment.ExitCode = 1;
 		}
 	}
 }