Skip to content

Commit fe70e8d

Browse files
committed
more colleen feedback
1 parent c0d019f commit fe70e8d

File tree

9 files changed

+74
-65
lines changed

9 files changed

+74
-65
lines changed

docs/_docset.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ toc:
3535
- file: move.md
3636
- file: redirects.md
3737
- file: cumulative-docs.md
38-
- file: deployment-models.md
38+
- file: branching-strategy.md
3939
- file: add-repo.md
4040
- folder: migration
4141
children:
@@ -74,7 +74,7 @@ toc:
7474
- file: navigation.md
7575
- file: extensions.md
7676
- file: page.md
77-
- file: deployment-models.md
77+
- file: content-sources.md
7878
- folder: syntax
7979
children:
8080
- file: index.md

docs/configure/deployment-models.md renamed to docs/configure/content-sources.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Content sources
22

3-
To support multiple deployment models for different repositories, we support the concept of a content source.
3+
To support multiple branching strategies for different repositories, we support the concept of a content source.
44

55
Next
66
: The source for the upcoming documentation.
@@ -17,16 +17,16 @@ Our publish environments are connected to a single content source.
1717
| Staging | `Current` |
1818
| Edge | `Next` |
1919

20-
This allows you as an owner of a repository to choose two different deployment models.
20+
This allows you as an owner of a repository to choose two different branching strategies.
2121

22-
## Deployment models
22+
## Branching strategies
2323

24-
The new documentation system supports 2 deployment models.
24+
The new documentation system supports 2 branching strategies.
2525

26-
Continuous deployment.
26+
Continuous deployment
2727
: This is the default where a repositories `main` or `master` branch is continuously deployed to production.
2828

29-
Tagged deployment
29+
Tagged
3030
: Allows you to 'tag' a single git reference (typically a branch) as `current` which will be used to deploy to production.
3131
Allowing you to control the timing of when new documentation should go live.
3232

@@ -56,7 +56,7 @@ references:
5656
% TODO we need navigation.yml docs
5757
Once the repository is added, its navigation still needs to be injected into to global site navigation.
5858
59-
### Tagged deployment
59+
### Tagged
6060
6161
If you want to have more control over the timing of when your docs go live to production. Configure the repository
6262
in our `assembler.yml` to have a fixed git reference (typically a branch) deploy the `current` content source to production.
@@ -75,7 +75,7 @@ Our CI integration checks will block until `current` is successfully configured
7575

7676
#### CI configuration
7777

78-
To ensure [tagged deployments](#tagged-deployment) can be onboarded correctly, our CI integration needs to have appropriate `push`
78+
To ensure repositories that use the [tagged branching strategy](#tagged) can be onboarded correctly, our CI integration needs to have appropriate `push`
7979
branch triggers.
8080

8181
```yml
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
:::{warning}
2-
Some repositories use a [tagged deployment model](/contribute/deployment-models.md), which means that their docs are published from a branch that is not `main` or `master`. In these cases, documentation changes need to be made to `main` or `master`, and then backported to the relevant branches.
2+
Some repositories use a [tagged branching strategy](/contribute/branching-strategy.md), which means that their docs are published from a branch that is not `main` or `master`. In these cases, documentation changes need to be made to `main` or `master`, and then backported to the relevant branches.
33

4-
For detailed backporting guidance, refer to the example in [Choose the docs deployment model for a repository](/contribute/deployment-models.md#workflow-2-tagged-deployment).
4+
For detailed backporting guidance, refer to the example in [Choose the docs branching strategy for a repository](/contribute/branching-strategy.md#workflow-2-tagged-deployment).
55

66
To determine the published branches for a repository, find the repository in [assembler.yml](https://github.com/elastic/docs-builder/blob/main/src/tooling/docs-assembler/assembler.yml).
77
:::

docs/contribute/add-repo.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ references:
5555
```
5656

5757
:::{tip}
58-
In this file, you can optionally specify custom branches to deploy docs from, depending on your preferred [deployment model](deployment-models.md). You might want to change your deployment model so you can have more control over when content added for a specific release is published.
58+
In this file, you can optionally specify custom branches to deploy docs from, depending on your preferred [branching strategy](branching-strategy.md). You might want to change your branching strategy so you can have more control over when content added for a specific release is published.
5959
:::
6060

6161
Then, edit the [navigation.yml](https://github.com/elastic/docs-builder/blob/main/src/tooling/docs-assembler/navigation.yml) file to add the repository to the navigation.

docs/contribute/deployment-models.md renamed to docs/contribute/branching-strategy.md

Lines changed: 32 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
---
2-
navigation_title: Choose a deployment model
2+
navigation_title: Choose a branching strategy
33
---
44

5-
# Choose the docs deployment model for a repository
5+
# Choose the docs branching strategy for a repository
66

7-
With Docs V3 (elastic.co/docs), a single branch is published per repository. This branch is set to `main` by default. This is known as the continuous deployment model. However, it is possible to instead publish a different branch, also known as the tagged deployment model.
7+
With Docs V3 (elastic.co/docs), a single branch is published per repository. This branch is set to `main` by default. This is known as the continuous deployment branching strategy. However, it is possible to instead publish a different branch, also known as the tagged branching strategy.
88

9-
On this page, you'll learn how to choose the right deployment model for your repository, and how to change the deployment model. You'll also learn about the workflows for working in each deployment model.
9+
On this page, you'll learn how to choose the right branching strategy for your repository, and how to change the branching strategy. You'll also learn about the workflows for working with each branching strategy.
1010

1111
## Why is `main` the default publication branch?
1212

@@ -25,38 +25,55 @@ Publishing from the main branch isn’t the best option for all repositories.
2525

2626
If you choose this publication model for your repository AND that repository includes {{serverless-short}} or {{ecloud}} documentation, you will need to make sure that {{serverless-short}}- and {{ecloud}}-related changes are also backported to the `current` branch in order to be published on time.
2727

28-
You **don't** need to change your deployment model to enable writing docs about future versions. Review the [continuous deployment workflow](#workflow-1-default-continuous-deployment) and [](cumulative-docs.md) to learn more.
28+
You **don't** need to change your branching strategy to enable writing docs about future versions. Review the [continuous deployment workflow](#workflow-1-default-continuous-deployment) and [](cumulative-docs.md) to learn more.
2929

3030
Note that regardless of the publication branch that is set, the documentation must still flag all changes introduced so far since the last major release. This is NOT an alternative to [writing docs cumulatively](cumulative-docs.md).
3131

3232
## How to change the published branch
3333

3434
Choosing to switch between publishing docs from `main` and publishing docs from a version branch is a long-term decision. This decision impacts all docs for an entire repository. Reach out to the docs team to discuss the change.
3535

36+
For more information, refer to [](/configure/content-sources.md).
37+
3638
After it has been established that a repository should publish from a version branch rather than `main`:
3739

38-
1. In the [docs assembler file](https://github.com/elastic/docs-builder/blob/main/src/tooling/docs-assembler/assembler.yml):
40+
1. [Add new triggers to the `docs-build` CI integration](/configure/content-sources.md#ci-configuration). Merge these changes to `main` or `master` and the intended version branches.
41+
2. Open a PR to trigger the CI integration and confirm that the docs build.
42+
3. Open a PR updating the [docs assembler file](https://github.com/elastic/docs-builder/blob/main/src/tooling/docs-assembler/assembler.yml):
3943
* Specify which is the `current` branch for the repository. This branch is the branch from which docs are deployed to production at [elastic.co/docs](http://elastic.co/docs).
4044
* Specify which is the `next` branch for the repository. The branch defined as `next` publishes docs internally to [staging-website.elastic.co/docs](http://staging-website.elastic.co/docs)
4145
* Setting this branch to the next version branch in line is a good practice to preview docs change for an upcoming version.
4246
* Otherwise, keeping it set to `main` is also an option since this is where the content is initially developed and merged. This is the default.
43-
2. [Add new triggers to the `docs-build` CI integration](/configure/deployment-models.md#ci-configuration).
44-
3. Add an action as part of that repo’s release process for the release manager to update this same assembler file and bump the `current` branch with each release, as appropriate. The `next` branch also needs to be bumped if it is not set to `main`.
45-
4. When these releases happen, create a PR against the [assembler file](https://github.com/elastic/docs-builder/blob/main/src/tooling/docs-assembler/assembler.yml) that defines the new `current` branch, to merge on release day.
47+
4. In the assembler PR, add the `ci` label. After CI runs, confirm that the intended version branches are publishing to the link service. When links are being published as intended, they can be found at the following URL, where `repo` is your repo name and `branch` is your newly configured branch:
48+
49+
```text
50+
elastic-docs-link-index.s3.us-east-2.amazonaws.com/elastic/<repo>/<branch>/links.json
51+
```
52+
5. Rerun the `validate-assembler` check on the PR.
53+
6. After checks pass and the docs engineering team approves, you can merge the PR.
54+
55+
After these steps are completed, the docs engineering team needs to release a new version of our build tool to complete the process. This process will be decoupled in a future release. After a new version is released, the switch is complete and the production documentation reflects the specified current branch.
56+
57+
### Update the release process
58+
59+
When you publish from specific version branches, you need to bump the version branch as part of the release process.
60+
61+
Add an action as part of that repo’s release process for the release manager to update this same assembler file and bump the `current` branch with each release, as appropriate. The `next` branch also needs to be bumped if it is not set to `main`.
62+
63+
When these releases happen, create a PR against the [assembler file](https://github.com/elastic/docs-builder/blob/main/src/tooling/docs-assembler/assembler.yml) that defines the new `current` branch, to merge on release day.
4664

47-
For more information, refer to [](/configure/deployment-models.md).
4865

4966
## Workflow 1 (default): Continuous deployment
5067

51-
Learn how to make updates in the continuous deployment model, where the repo is publishing docs from `main`.
68+
Learn how to make updates in the continuous deployment branching strategy, where the repo is publishing docs from `main`.
5269

5370
### Where to make docs changes [make-changes-cd]
5471

5572
Initiate the changes by opening a PR against the `main` branch of the repo.
5673

5774
### How to write those changes [write-changes-cd]
5875

59-
In our markdown-based documentation system, we [write docs cumulatively](cumulative-docs.md) regardless of the publication model selected.
76+
In elastic.co/docs (Docs V3), we [write docs cumulatively](cumulative-docs.md) regardless of the branching strategy selected.
6077

6178
### Merging and backporting [merge-backport-cd]
6279

@@ -74,21 +91,17 @@ When a repo is publishing docs from its `main` branch, no backporting is needed.
7491
If you don’t want to hold on too many PRs to publish on release day, merge them to a feature branch, so you only have to merge this feature branch to `main` on release day.
7592
:::
7693

77-
### More examples [more-examples-cd]
78-
79-
We’ve prepared a few end-to-end examples to help in [Figma](https://www.figma.com/design/CZDl0szuGsQfJhFpnwJVWS/Applies_to-Docs-V3?node-id=0-1&p=f&t=lBPrvde0k5zg9U0E-0).
80-
81-
## Workflow 2: Tagged deployment
94+
## Workflow 2: Tagged
8295

83-
Learn how to make updates in the continuous deployment model, where the repo is publishing docs from a specific `version` branch.
96+
Learn how to make updates in the continuous deployment branching strategy, where the repo is publishing docs from a specific `version` branch.
8497

8598
### Where to make docs changes [make-changes-td]
8699

87100
Initiate the changes by opening a PR against the `main` branch of the repo. The changes will be backported to the relevant version branches as detailed below.
88101

89102
### How to write those changes [write-changes-td]
90103

91-
In our markdown-based documentation system, we [write docs cumulatively](cumulative-docs.md) regardless of the publication model selected.
104+
In elastic.co/docs (Docs V3), we [write docs cumulatively](cumulative-docs.md) regardless of the branching strategy selected.
92105

93106
### Merging and backporting [merge-backport-td]
94107

@@ -117,7 +130,3 @@ For example, in a situation where 9.0, 9.1, and 9.2 are already released, and th
117130
:::{note}
118131
While you *can* backport to versions prior to the `current` version when applicable to maintain parity between the code and the docs on a given branch, that content will not be used in the current state of the docs.
119132
:::
120-
121-
### More examples [more-examples-td]
122-
123-
We’ve prepared a few end-to-end examples to help in [Figma](https://www.figma.com/design/CZDl0szuGsQfJhFpnwJVWS/Applies_to-Docs-V3?node-id=0-1&p=f&t=lBPrvde0k5zg9U0E-0).

docs/contribute/cumulative-docs.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
This page explains our cumulative documentation philosophy, paired with examples. Component guidance for reference purposes goes in syntax/applies.md.
55
-->
66

7-
In our markdown-based documentation system, we write docs cumulatively regardless of the [deployment model](deployment-models.md) selected.
7+
In elastic.co/docs (Docs V3), we write docs cumulatively regardless of the [branching strategy](branching-strategy.md) selected.
88

99
**What does this mean?**
1010

@@ -109,7 +109,7 @@ For this case, no specific version tagging is necessary.
109109
**A new feature is added to {{serverless-short}} or {{ecloud}}. How do I tag it?**
110110
Cumulative documentation is not meant to replace release notes. If a feature becomes available in {{serverless-short}} and doesn’t have a particular lifecycle state to call out (preview, beta, deprecated…), it does not need specific tagging.
111111

112-
However, in this scenario, it is important to consider carefully [when the change is going to be published](deployment-models.md).
112+
However, in this scenario, it is important to consider carefully [when the change is going to be published](branching-strategy.md).
113113

114114
We do not do date-based tagging for unversioned products.
115115

docs/contribute/index.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,6 @@ In April 2025, we released our new documentation site. This site includes docume
1515
:::{include} _snippets/two-systems.md
1616
:::
1717

18-
### Contribute to elastic.co/guide
19-
20-
:::{include} _snippets/guide-intro.md
21-
:::
22-
23-
* For **simple bug fixes and enhancements**: [Contribute on the web](on-the-web.md)
24-
* For **complex or multi-page updates**: See the [legacy documentation build guide](https://github.com/elastic/docs?tab=readme-ov-file#building-documentation)
25-
2618
### Contribute elastic.co/docs
2719

2820
:::{include} _snippets/docs-intro.md
@@ -35,7 +27,15 @@ In April 2025, we released our new documentation site. This site includes docume
3527

3628
In Docs V3, a single branch is published per repository. This branch is set to `main` by default, but it is possible to instead publish a different branch by changing your repository's deployment model. You might want to change your deployment model so you can have more control over when content added for a specific release is published.
3729

38-
[Learn more about deployment models](deployment-models.md).
30+
[Learn more about branching strategies](branching-strategy.md).
31+
32+
### Contribute to elastic.co/guide
33+
34+
:::{include} _snippets/guide-intro.md
35+
:::
36+
37+
* For **simple bug fixes and enhancements**: [Contribute on the web](on-the-web.md)
38+
* For **complex or multi-page updates**: See the [legacy documentation build guide](https://github.com/elastic/docs?tab=readme-ov-file#building-documentation)
3939

4040
## Report a bug
4141

docs/contribute/on-the-web.md

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,38 +7,38 @@ This section will help you understand how to update and contribute to our docume
77
:::{include} _snippets/two-systems.md
88
:::
99

10-
### Update elastic.co/guide [guide]
10+
### Update elastic.co/docs (Docs V3) [docs]
1111

12-
:::{include} _snippets/guide-intro.md
12+
:::{include} _snippets/docs-intro.md
1313
:::
1414

15-
These changes should be made in the original source folders in their respective repositories. Here’s how you can do it:
15+
For content hosted on elastic.co/docs, most conceptual and narrative content is stored in the [`docs-content`](https://github.com/elastic/docs-content) repository, and most reference content is hosted in the relevant product's repository. Follow these steps to ensure your contributions are correctly made:
1616

1717
1. Navigate to the page that is impacted.
1818
2. Click the **Edit** button.
19-
3. Ensure the targeted branch is \<insert proper branch\>.
19+
3. Identify the section that requires updates.
2020
4. Make the necessary updates.
21-
5. Commit your changes and create a pull request.
22-
6. Add the appropriate labels per repo as found at [Page: Working across docs repos](https://elasticco.atlassian.net/wiki/spaces/DOC/pages/61604182/Working+across+docs+repos)
21+
5. Commit your changes and create a pull request.
2322

24-
:::{note}
25-
If you are working in a repo like Kibana or the cloud repo, backports can be complicated. You can use the [backport tool](https://github.com/sorenlouv/backport) to manage your backport.
23+
:::{include} _snippets/tagged-warning.md
2624
:::
2725

28-
### Update elastic.co/docs [docs]
26+
### Update elastic.co/guide [guide]
2927

30-
:::{include} _snippets/docs-intro.md
28+
:::{include} _snippets/guide-intro.md
3129
:::
3230

33-
For content hosted on elastic.co/docs, most conceptual and narrative content is stored in the [`docs-content`](https://github.com/elastic/docs-content) repository, and most reference content is hosted in the relevant product's repository. Follow these steps to ensure your contributions are correctly made:
31+
These changes should be made in the original source folders in their respective repositories. Here’s how you can do it:
3432

3533
1. Navigate to the page that is impacted.
3634
2. Click the **Edit** button.
37-
3. Identify the section that requires updates.
35+
3. Ensure the targeted branch is \<insert proper branch\>.
3836
4. Make the necessary updates.
39-
5. Commit your changes and create a pull request.
37+
5. Commit your changes and create a pull request.
38+
6. Add the appropriate labels as required by the repo. To learn which labels to add, refer to the contribution documentation for that repo or reach out to the file codeowners.
4039

41-
:::{include} _snippets/tagged-warning.md
40+
:::{note}
41+
If you are working in a repo like Kibana or the cloud repo, backports can be complicated. You can use the [backport tool](https://github.com/sorenlouv/backport) to manage your backport.
4242
:::
4343

4444
## What if I need to update docs in both systems?

docs/migration/versioning.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ In this new system, documentation is written **cumulatively**. This means that a
1515
:::{include} /contribute/_snippets/tag-processing.md
1616
:::
1717

18-
## Deployment models
18+
## Branching strategy
1919

20-
In Docs V3, a single branch is published per repository. This branch is set to `main` by default, but it is possible to instead publish a different branch by changing your repository's deployment model. You might want to change your deployment model so you can have more control over when content added for a specific release is published.
20+
In Docs V3, a single branch is published per repository. This branch is set to `main` by default, but it is possible to instead publish a different branch by changing your repository's branching strategy. You might want to change your branching strategy so you can have more control over when content added for a specific release is published.
2121

22-
* [Learn how to choose the right deployment model for your repository](/contribute/deployment-models.md)
23-
* [Learn how to set up your selected deployment model](/configure/deployment-models.md)
22+
* [Learn how to choose the right branching strategy for your repository](/contribute/branching-strategy.md)
23+
* [Learn how to set up your selected branching strategy](/configure/content-sources.md)

0 commit comments

Comments
 (0)