-
Notifications
You must be signed in to change notification settings - Fork 32
Description
Prerequisites
- I have searched existing issues to ensure this feature hasn't already been requested
- I have tested using the latest version of docs-builder
What problem are you trying to solve?
In the asciidoc system, we don't show "edit" buttons in our cloud books (e.g. cloud or cloud enterprise) because the repo is private. instead, we add a query param to the url to expose the edit option: ?edit
because we have content coming from private repos in the v3 system, we should similarly hide the Edit this page option on pages that external contributors can't edit, but also make some sort of way to unhide it for elasticians.
If we don't do this, external contributors will see an ugly github error page, which might feel broken, or dissuade them from contributing elsewhere
Proposed Solution
probably use the query param again because people are used to it: ?edit
use the query param to dynamically show/hide the edit button
consider storing some sort of cookie so editing is always on for these users?
Examples and Research
No response
Alternative Solutions
anything else that hides the button and conditionally shows it to elastic users works for me
Additional Context
No response
How important is this feature to you?
Important