feature/limited width layout 4 #1201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reakaleek
approved these changes
Apr 30, 2025
Co-authored-by: Jan Calanog <[email protected]>
Mpdreamz
merged commit 8415fc8
into
feature/limited-width-layout-2
13 of 14 checks passed
Mpdreamz
added a commit
that referenced
this pull request
May 1, 2025
* Full width layout PoC * Also set max width for other elements * Fixes and fine-tuning * Cleanup * Fix isolated build header position * Formatting * Prettier * Limited max width PoC * Use common resolution width * Dynamic spacing for max-width layout * ensure margins are dynamic again * fix css lint * Slight on this page margin adjustments (#1198) * feature/limited width layout 4 (#1201) * fixate max-width around max content-width * npm fix lint * Update src/Elastic.Markdown/Slices/_Layout.cshtml Co-authored-by: Jan Calanog <[email protected]> --------- Co-authored-by: Jan Calanog <[email protected]> --------- Co-authored-by: Jan Calanog <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cursorful-video-1746019180296.mp4
Continuation of #1197
Instead of having variable gaps this now refocusses on having a dynamic
max-layout-widthbased on ensuring theres enough space for the side bars + 90characters of content.This normalizes margins and creates calmer reading experience (IMO of course :))
The header menu and footer also follow
max-layout-widthnow ensuring they match the content boundaries.This also opens up the possibility to create a dedicated ultra large media experience if we ever want to go beyond
90chor create a bit more margin for wide screens.