-
Notifications
You must be signed in to change notification settings - Fork 32
Publish beats docs from the 9.0 branch
#1345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9.0 branch
| apm-k8s-attacher: | ||
| beats: | ||
| current: "9.0" | ||
| next: main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have next as 9.1? That would ensure we don't publish main again by accident and that once v9.1.0 is released, there won't be any unreleased features in our docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
next only refers to which branch will be published to our internal staging site. There's no automation in place that will replace the current value with the next value.
As more repos start using different current / next branches (and as development in this repo continues), we'll likely replace the value of current with a variable like stack_version and the docs release manager will be responsible for updating the latest Stack version just like we did with AsciiDoc.
(@Mpdreamz please correct me if I got anything wrong!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You didn't :)
|
This LGTM we just need to wait for And its backport to After that ci / validate-assembler (pull_request)` can be rerun and should go green. |
Mpdreamz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://elastic-docs-link-index.s3.us-east-2.amazonaws.com/link-index.json looking good and checks are happy.
LGTM, can I wait merging this till Monday? We need to do a new release to get the assembler.yml to production.
|
Ahh automerge! :) Will wait with releasing this and ensuring production reflects assembler.yml till monday. |
|
Sorry! 🙈 |
Update assembler config to publish Beats documentation from the
9.0branch.cc @belimawr