-
Notifications
You must be signed in to change notification settings - Fork 32
More docs updates #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
More docs updates #136
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ebd1e7a
more docs updates
bmorelli25 2003e3c
sync readmes
bmorelli25 28a6120
add migration and contribution guide placeholders
bmorelli25 76281a4
fix image
bmorelli25 ff0bb49
small update
bmorelli25 a3c2e6d
add configure, contribution, and migration guides
bmorelli25 75f2fff
add more content
bmorelli25 5f5d23d
fix bug?
bmorelli25 ceb422f
remove link
bmorelli25 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| --- | ||
| title: Elastic Docs contribution guide | ||
| navigation_title: Contribution guide | ||
| --- | ||
|
|
||
| Want to contribute to the Elastic documentation? You're in the right spot! | ||
|
|
||
| 1. Install dependencies | ||
| 2. Clone repositories | ||
| 3. Make changes | ||
| 4. Open a Pull Request | ||
| 5. Work with CI | ||
| 6. Get approvals and merge | ||
| 7. View your changes live on elastic.co |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,7 +28,7 @@ Options: | |
| Commands: | ||
| generate Converts a source markdown folder or file to an output folder | ||
| serve Continuously serve a documentation folder at http://localhost:5000. | ||
| File systems changes will be reflected without having to restart the server. | ||
| File systems changes will be reflected without having to restart the server. | ||
| ``` | ||
|
|
||
| In the near term native code will be published by CI for the following platforms | ||
|
|
@@ -44,7 +44,8 @@ And we'll invest time in making sure these are easily obtainable (`brew`, `winge | |
| For now you can run the tool locally through `docker run` | ||
|
|
||
| ```bash | ||
| docker run -v "./.git:/app/.git" -v "./docs:/app/docs" -v "./.artifacts:/app/.artifacts" ghcr.io/elastic/docs-builder:edge | ||
| docker run -v "./.git:/app/.git" -v "./docs:/app/docs" -v "./.artifacts:/app/.artifacts" \ | ||
| ghcr.io/elastic/docs-builder:edge | ||
| ``` | ||
|
|
||
| This ensures `.git`/`docs` and `.artifacts` (the default output directory) are mounted. | ||
|
|
@@ -54,15 +55,17 @@ Only the changed files on subsequent runs will be compiled unless you pass `--fo | |
| to force a new compilation. | ||
|
|
||
| ```bash | ||
| docker run -v "./.git:/app/.git" -v "./docs:/app/docs" -v "./.artifacts:/app/.artifacts" ghcr.io/elastic/docs-builder:edge --force | ||
| docker run -v "./.git:/app/.git" -v "./docs:/app/docs" -v "./.artifacts:/app/.artifacts" \ | ||
| ghcr.io/elastic/docs-builder:edge --force | ||
| ``` | ||
|
|
||
| #### Live mode | ||
|
|
||
| Through the `serve` command you can continuously and partially compile your documentation. | ||
|
|
||
| ```bash | ||
| docker run -v "./.git:/app/.git" -v "./docs:/app/docs" -v "./.artifacts:/app/.artifacts" --expose 8080 ghcr.io/elastic/docs-builder:edge serve | ||
| docker run -v "./.git:/app/.git" -v "./docs:/app/docs" -v "./.artifacts:/app/.artifacts" \ | ||
| -p 8080:8080 ghcr.io/elastic/docs-builder:edge serve | ||
| ``` | ||
|
|
||
| Each page is compiled on demand as you browse http://localhost:8080 and is never cached so changes to files and | ||
|
|
@@ -130,18 +133,20 @@ https://github.com/elastic/{your-repository}/settings/pages | |
|
|
||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There are two differences between this file and the readme:
|
||
| ## Run without docker | ||
|
|
||
| If you have dotnet 8 installed you can use its CLI to publish a self-contained `docs-builder` native code | ||
| You can use the .NET CLI to publish a self-contained `docs-builder` native code | ||
| binary. (On my M2 Pro mac the binary is currently 16mb) | ||
|
|
||
| Install [.NET 9.0](https://dotnet.microsoft.com/en-us/download/dotnet/9.0), then run: | ||
|
|
||
| ```bash | ||
| $ dotnet publish "src/docs-builder/docs-builder.csproj" | ||
| dotnet publish "src/docs-builder/docs-builder.csproj" | ||
| ``` | ||
|
|
||
| The resulting binary `./.artifacts/publish/docs-builder/release/docs-builder` will run on machines without .NET installed | ||
| The resulting binary `./.artifacts/publish/docs-builder/release/docs-builder` will run on machines without .NET installed. | ||
|
|
||
| # Performance | ||
|
|
||
| To test performance it's best to build the binary and run outside of docker: | ||
|
|
||
| For refence here's the `markitpy-doc` docset (50k markdown files) currently takes `14s` vs `several minutes` compared to | ||
| For reference here's the `markitpy-doc` docset (50k markdown files) currently takes `14s` vs `several minutes` compared to | ||
| existing surveyed tools | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| --- | ||
| title: Migrate from Asciidoc to V3 | ||
| navigation_title: Migration guide | ||
| --- | ||
|
|
||
| How to migrate content from Asciidoc to V3. | ||
|
|
||
| 1. Clone https://github.com/elastic/adoc-to-md | ||
| 2. Run the migration tool | ||
| 3. Copy the output to the appropriate directory in https://github.com/elastic/docs-content | ||
| 4. Update the `docset.yml` file to reflect the new IA of the content set | ||
| 5. Build your changes with https://github.com/elastic/docs-builder | ||
| 6. Open a PR and merge your changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.