Skip to content

Icons #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jun 30, 2025
Merged

Icons #1413

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
7808089
PoC: Icons
reakaleek Jun 23, 2025
69b43a4
Update docs/syntax/icons.md
reakaleek Jun 23, 2025
874632f
Update docs/syntax/icons.md
reakaleek Jun 23, 2025
96a32a7
Add aria-label
reakaleek Jun 23, 2025
6f62f40
Use output/markdown pattern in docs
reakaleek Jun 23, 2025
e45efec
Remove `i`-prefix from icon syntax
reakaleek Jun 23, 2025
7ccba83
Fix docs
reakaleek Jun 23, 2025
6769762
Fix docs
reakaleek Jun 23, 2025
9dd4ee6
Naming
reakaleek Jun 23, 2025
d3d7b10
Refactor to role instead of inline parser
reakaleek Jun 29, 2025
66780ca
cleanup
reakaleek Jun 29, 2025
660e08b
Merge branch 'main' into feature/icons
reakaleek Jun 29, 2025
d0fd929
cleanup
reakaleek Jun 29, 2025
79c8154
Naming
reakaleek Jun 29, 2025
66337ea
table styling
reakaleek Jun 29, 2025
36b67d2
Simplify test
reakaleek Jun 29, 2025
91fc82b
Remove obsolete surpress message
reakaleek Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions docs/_docset.yml
View file
Open in desktop
Copy link
Contributor

@cotti cotti Jun 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not an issue in the PR, but in GH) What a weird false positive... If you open this in a hex editor, U+2009 (0xE2 0x80 0x89) is nowhere to be seen.

Copy link
Member Author

@reakaleek reakaleek Jun 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you mean the error in the failing test. I was not able to find a difference and I don't think this error will cause any troubles in production.

We might feel the pain when we add tests in the future 😅

But I think the simplified test is testing the necessary parts. Which is fine.

Thank you for checking.

Copy link
Contributor

@theletterf theletterf Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're referring to the docs-build hints, it's not a false positive, the character really is invisible. It should be a space or not a space. Easy to catch with a regex such as \u2009 if I remember well. I fixed most of those in another PR, so a rebase should do the trick.

Copy link
Member Author

@reakaleek reakaleek Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I had a test that was failing only in windows.

The error said that the output doesn't match the expected. But it was exactly the same.

Hence, @cotti suspected that there must be a weird space or something.

Copy link
Member Author

@reakaleek reakaleek Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, I actually misunderstood this haha :D

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
project: 'doc-builder'

Check notice on line 1 in docs/_docset.yml

View workflow job for this annotation

GitHub Actions / build 

Irregular whitespace character detected: U+2009 (Thin Space). This may impair Markdown rendering.

Check notice on line 1 in docs/_docset.yml

View workflow job for this annotation

GitHub Actions / build 

Irregular whitespace character detected: U+2009 (Thin Space). This may impair Markdown rendering.

Check notice on line 1 in docs/_docset.yml

View workflow job for this annotation

GitHub Actions / build 

Irregular whitespace character detected: U+2009 (Thin Space). This may impair Markdown rendering.

Check notice on line 1 in docs/_docset.yml

View workflow job for this annotation

GitHub Actions / build 

Irregular whitespace character detected: U+2009 (Thin Space). This may impair Markdown rendering.

Check notice on line 1 in docs/_docset.yml

View workflow job for this annotation

GitHub Actions / build 

Irregular whitespace character detected: U+2009 (Thin Space). This may impair Markdown rendering.

Check notice on line 1 in docs/_docset.yml

View workflow job for this annotation

GitHub Actions / build 

Irregular whitespace character detected: U+2009 (Thin Space). This may impair Markdown rendering.

Check notice on line 1 in docs/_docset.yml

View workflow job for this annotation

GitHub Actions / build 

Irregular whitespace character detected: U+2009 (Thin Space). This may impair Markdown rendering.
max_toc_depth: 2
# indicates this documentation set is not linkable by assembler.
# relaxes a few restrictions around toc building and file placement
Expand Down Expand Up @@ -84,6 +84,7 @@
- file: example_blocks.md
- file: file_inclusion.md
- file: frontmatter.md
- file: icons.md
- file: images.md
- file: lists.md
- file: line_breaks.md
Expand Down
Loading
Loading