From 9b44e21c1cb9be45c923bef9a90b656b828e0622 Mon Sep 17 00:00:00 2001 From: Jan Calanog Date: Tue, 7 Jan 2025 12:22:27 +0100 Subject: [PATCH 1/2] Add a sentence on how to fix the external URI warning --- .../Myst/InlineParsers/DiagnosticLinkInlineParser.cs | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/Elastic.Markdown/Myst/InlineParsers/DiagnosticLinkInlineParser.cs b/src/Elastic.Markdown/Myst/InlineParsers/DiagnosticLinkInlineParser.cs index 9bbd79e59..a66c7ec03 100644 --- a/src/Elastic.Markdown/Myst/InlineParsers/DiagnosticLinkInlineParser.cs +++ b/src/Elastic.Markdown/Myst/InlineParsers/DiagnosticLinkInlineParser.cs @@ -62,7 +62,15 @@ public override bool Match(InlineProcessor processor, ref StringSlice slice) { var baseDomain = string.Join('.', uri.Host.Split('.')[^2..]); if (!context.Configuration.ExternalLinkHosts.Contains(baseDomain)) - processor.EmitWarning(line, column, length, $"external URI: {uri} "); + { + processor.EmitWarning( + line, + column, + length, + $"External URI '{uri}' is not allowed. Add '{baseDomain}' to the " + + $"'external_hosts' list in {context.Configuration.SourceFile} to " + + "allow links to this domain."); + } return match; } From f3e609a326b1ec7018a24c39ce343b36a292febf Mon Sep 17 00:00:00 2001 From: Jan Calanog Date: Tue, 7 Jan 2025 12:26:43 +0100 Subject: [PATCH 2/2] Fix linting errors (extra whitespace) --- .../Myst/InlineParsers/DiagnosticLinkInlineParser.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Elastic.Markdown/Myst/InlineParsers/DiagnosticLinkInlineParser.cs b/src/Elastic.Markdown/Myst/InlineParsers/DiagnosticLinkInlineParser.cs index a66c7ec03..42f9c75c9 100644 --- a/src/Elastic.Markdown/Myst/InlineParsers/DiagnosticLinkInlineParser.cs +++ b/src/Elastic.Markdown/Myst/InlineParsers/DiagnosticLinkInlineParser.cs @@ -64,9 +64,9 @@ public override bool Match(InlineProcessor processor, ref StringSlice slice) if (!context.Configuration.ExternalLinkHosts.Contains(baseDomain)) { processor.EmitWarning( - line, - column, - length, + line, + column, + length, $"External URI '{uri}' is not allowed. Add '{baseDomain}' to the " + $"'external_hosts' list in {context.Configuration.SourceFile} to " + "allow links to this domain.");