Optimize lazy load navigation #1514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
requested changes
Jul 7, 2025
| public required string Id { get; init; } | ||
| } | ||
|
|
||
| public record EmptyNavigationRenderResult : INavigationRenderResult |
Member
There was a problem hiding this comment.
This can be a static property on OkNavigationRenderResult ?
e.g OkNavigationRenderResult.Empty then we can just have a single record NavigationRenderResult without an interface.
Mpdreamz
requested changes
Jul 7, 2025
src/Elastic.Documentation.Site/Navigation/INavigationHtmlWriter.cs
Outdated
Show resolved
Hide resolved
…r.cs Co-authored-by: Martijn Laarman <[email protected]>
Mpdreamz
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
follow-up from #1505
Currently we are create a .nav.html file for every page that exists.
However, there are many duplicates as the navigation for sub pages are probably the same.
Changes