Fix RoleParser #1536
Merged
Fix RoleParser #1536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
🔍 Preview links for changed docs |
Merged
Mpdreamz
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1523
Context
Only in some cases (depending on the content length) the RoleParser would parse incorrect content.
E.g. if the icon is
{icon}`pencil`,contentSpanwould result inpencil`(a trailing space and trailing backtick)The previous fix to this problem was just to add
.Trim()to the existingcontentSpan.Trim('`').But this caused the trailing space to also disappear in the final HTML output, which was reported in #1523.
Changes
Fix the logic to determine the closing backtick.
Preview
Here you can see that the space is now correctly rendered in the final html output.