-
Notifications
You must be signed in to change notification settings - Fork 32
Allow subs in stepper headings #1659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔍 Preview links for changed docs |
|
@eedugon You can test it out here: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/1659/contribute/locally#run-docs-builder The source for that step title is https://github.com/elastic/docs-builder/pull/1659/files#diff-04d89933862130b932e71ef5f244ca08fb9084c587a25ca2be796133f7fb3f84R148 |
|
@elastic/docs-engineering Please have a look — thanks! |
|
I'm wondering if we could use the actual HTML renderer for rendering the heading. This would then cover all the things. |
|
@reakaleek PTAL! |
Ah, sorry for being ambiguous. I meant like.. the markdig renderer. So that all markdown syntax is covered. |
|
We already override parsing headers here: But no custom renderer yet.. Not sure we need it as the headers are already parsed and pick up subs. |
|
But not sure I understand completely @reakaleek the stepper circumvents markdown headers by using its own renderer? You want the renderer to call the default markdown header renderer which already parses and replaces subs? instead of using |
I think we could either recursively, or use the existing static markdown pipeline to render the LeafInline or something like that. That way the heading would support all the things our markdown supports. |
I'm not sure.. if what I'm trying to convey would work.. you could remove the custom |
|
@Mpdreamz @reakaleek I think it's ready now! |
Fixes #1658