-
Notifications
You must be signed in to change notification settings - Fork 32
Allow specifying custom path locally in assembler.yml #1756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Mpdreamz
merged 13 commits into
main
from
feature/integration-tests-with-docs-builder-in-assembler
Aug 21, 2025
Merged
Allow specifying custom path locally in assembler.yml #1756
Mpdreamz
merged 13 commits into
main
from
feature/integration-tests-with-docs-builder-in-assembler
Aug 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes setup instructions, local services management, Elasticsearch instance configuration, user secrets, and tokenless CI workflows.
Only works locally. If you specify `--skip-private-repositories` locally and we detect a solution file we automatically inject docs-builder in to the assembler navigation. This allows our integration tests to tests new features in the assembler.
…emove unused import in integration tests
🔍 Preview links for changed docs |
cotti
approved these changes
Aug 21, 2025
Contributor
cotti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Gonna be interesting to see how much more we can stretch Aspire in the future.
Contributor
|
Sweet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You may now set
pathlocally inassembler.ymlto point to a local checkout of a documentation set to ease validation changes on the asssembled build.This is not allowed on
CIandpathwill be cleared automatically if its set.Integration tests with local docs-builder docs
This now also re-enables our integration tests and it uses this feature to inject:
docsfolder fromdocs-builderaspathinassembler.yml(and unsettingskip.This allows our CI to validate changes to
docset.ymlto our assemble process.Updates to our aspire setup.
Our Aspire set up has now moved to a more logical place and makes it dead easy to start all services locally:
Or if you want faster local builds you can do:
I added a more in depth readme to document the why and how of our aspire setup.
https://github.com/elastic/docs-builder/blob/e37dbfd50b04ffdcaff6481bc98f47008bfeb034/aspire/README.md