-
Notifications
You must be signed in to change notification settings - Fork 32
Update applies_to example for same lifecycle, multiple versions
#1945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔍 Preview links for changed docs |
|
@Mpdreamz Most interesting! Why do we get a preview only for one of the two files that have been changed? Is it because the change is in a snippet doc? |
| ## Functionality is added to multiple patch versions [multiple-patch] | ||
|
|
||
| Sometimes, features and enhancements slip through into patch versions. In that case, the same functionality might be added for the first time to multiple patch versions at the same time. | ||
| Sometimes, features and enhancements slip through into patch versions, and the same functionality might be added for the first time to multiple patch versions at the same time. In that case, use two `applies_to` badges so that users can see clearly the versions in which the functionality is introduced. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a note that the author should manually ensure that the applies_tos should be in order: starting with later versions, ending with earlier versions? (The auto-ordering doesn't work when there are multiple inline applies_tos.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
With docs-builder 0.72.0, the rendering of one
applies_towith multiple values has changed. This requires changes in the guidelines for usingapplies_tofor functionality that becomes available in the same lifecycle in multiple versions.This PR updates the Functionality is added to multiple patch versions example scenario with a recommendation to use multiple
applies_totags in such cases.It also adds an example of such a use case in the Applies to style guide section.