Skip to content

Allow multiple classic callouts in one line #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 28, 2025
Merged

Allow multiple classic callouts in one line #355

merged 5 commits into from
Jan 28, 2025

Conversation

@reakaleek
Copy link
Member

@reakaleek reakaleek commented Jan 28, 2025 •
edited
Loading

Closes #175

Changes

Allow multiple classic callouts in a single line.

image

@reakaleek reakaleek force-pushed the feature/multiple-callouts branch 2 times, most recently from 8de8b26 to f640973 Compare January 28, 2025 10:33
@reakaleek reakaleek force-pushed the feature/multiple-callouts branch from f640973 to 3fa6a22 Compare January 28, 2025 10:39
@reakaleek reakaleek requested a review from a team January 28, 2025 10:43
@reakaleek reakaleek added the fix label Jan 28, 2025
@reakaleek reakaleek self-assigned this Jan 28, 2025
@reakaleek reakaleek marked this pull request as ready for review January 28, 2025 10:43
@reakaleek reakaleek mentioned this pull request Jan 28, 2025
Closed
@reakaleek
Copy link
Member Author

reakaleek commented Jan 28, 2025

Reverting to draft, it's broken if there is a < within the code

```csharp

app.UseFilter<StopwatchFilter>(); <1>
app.UseFilter<CatchExceptionFilter>(); <2>

var x = 1; <1>
var y = x - 2;
var z = y - 2; <1> <2>
```

@reakaleek reakaleek marked this pull request as draft January 28, 2025 10:56
Mpdreamz
Mpdreamz approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@reakaleek
Copy link
Member Author

reakaleek commented Jan 28, 2025 •
edited
Loading

Reverting to draft, it's broken if there is a < within the code

```csharp

app.UseFilter<StopwatchFilter>(); <1>
app.UseFilter<CatchExceptionFilter>(); <2>

var x = 1; <1>
var y = x - 2;
var z = y - 2; <1> <2>
```

Fixed by 7e318b2

@reakaleek reakaleek marked this pull request as ready for review January 28, 2025 11:57
@reakaleek reakaleek requested a review from Mpdreamz January 28, 2025 12:02
@reakaleek reakaleek merged commit a1deace into main Jan 28, 2025
5 checks passed
@reakaleek reakaleek deleted the feature/multiple-callouts branch January 28, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees

@reakaleek reakaleek

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Code block callouts do not render in code

3 participants

@reakaleek @Mpdreamz