Skip to content

Conversation

@reakaleek
Copy link
Member

No description provided.

@reakaleek reakaleek added the automation packaging, ci/cd. label Jan 28, 2025
@reakaleek reakaleek self-assigned this Jan 28, 2025
@reakaleek reakaleek requested a review from a team January 28, 2025 12:32
@reakaleek
Copy link
Member Author

@bmorelli25 WDYT about this?

This is not blocking, since it won't be a required status check. However, the check will be clearly red.

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it 👍

@reakaleek reakaleek merged commit 0da3f8d into main Jan 29, 2025
5 of 6 checks passed
@reakaleek reakaleek deleted the feature/ascciidoc-comment-error branch January 29, 2025 08:49
reakaleek added a commit that referenced this pull request Jan 29, 2025
* Optimize comment-on-asciidoc-changes.yml

* Checkout correct commit when used with pull_request_target

* Update .github/workflows/comment-on-asciidoc-changes.yml

* Add error exit code if there are changes for the asciidoc comment workflow (#357)

* Merge main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation packaging, ci/cd.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants