Skip to content

Commit 88f7d55

Browse files
authored
Enable strict mode (zero warnings) (#494)
Fixes all remaining warnings. --------- Signed-off-by: bmorelli25 <[email protected]>
1 parent 4df3eda commit 88f7d55

File tree

72 files changed

+108
-313
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

72 files changed

+108
-313
lines changed

.github/workflows/docs-build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
uses: elastic/docs-builder/.github/workflows/preview-build.yml@main
1212
with:
1313
continue-on-error: false
14-
strict: false
14+
strict: true
1515
permissions:
1616
deployments: write
1717
id-token: write

deploy-manage/cloud-organization/billing/manage-subscription.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ To change your subscription level:
3939

4040
### Feature usage notifications [ec_feature_usage_notifications]
4141

42-
:::{applies}
42+
:::{applies_to}
4343
:hosted: all
4444
:::
4545

deploy-manage/deploy/cloud-enterprise/manage-elastic-stack-versions.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ You can add new Elastic Stack packs to your installation through the Cloud UI, t
348348

349349
To add a new Elastic Stack pack from the Cloud UI:
350350

351-
1. Download the [Elastic Stack version]() that you want.
351+
1. Download the Elastic Stack version that you want.
352352
2. [Log into the Cloud UI](log-into-cloud-ui.md).
353353
3. From the **Platform** menu, select **Elastic Stack**.
354354
4. Select **Upload Elastic Stack pack**.

deploy-manage/deploy/cloud-on-k8s/configuration-fleet.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ spec:
9292
* `xpack.fleet.agents.elasticsearch.hosts` must point to the {{es}} cluster where {{agents}} should send data. For ECK-managed {{es}} clusters ECK creates a Service accessible through `https://ES_RESOURCE_NAME-es-http.ES_RESOURCE_NAMESPACE.svc:9200` URL, where `ES_RESOURCE_NAME` is the name of {{es}} resource and `ES_RESOURCE_NAMESPACE` is the namespace it was deployed within. See [Storing local state in host path volume](configuration-examples-standalone.md#k8s_storing_local_state_in_host_path_volume) for details on adjusting this field when running agent as non-root as it becomes required.
9393
* `xpack.fleet.agents.fleet_server.hosts` must point to {{fleet-server}} that {{agents}} should connect to. For ECK-managed {{fleet-server}} instances, ECK creates a Service accessible through `https://FS_RESOURCE_NAME-agent-http.FS_RESOURCE_NAMESPACE.svc:8220` URL, where `FS_RESOURCE_NAME` is the name of {{agent}} resource with {{fleet-server}} enabled and `FS_RESOURCE_NAMESPACE` is the namespace it was deployed in.
9494
* `xpack.fleet.packages` are required packages to enable {{fleet-server}} and {{agents}} to enroll.
95-
* `xpack.fleet.agentPolicies` policies are needed for {{fleet-server}} and {{agents}} to enroll to, check {{fleet-guide}}/agent-policy.html for more information.
95+
* `xpack.fleet.agentPolicies` policies are needed for {{fleet-server}} and {{agents}} to enroll to, check https://www.elastic.co/guide/en/fleet/current/agent-policy.html for more information.
9696

9797

9898
## Set referenced resources [k8s-elastic-agent-fleet-configuration-setting-referenced-resources]

deploy-manage/deploy/cloud-on-k8s/logstash-plugins.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ mapped_pages:
77

88
# Logstash plugins [k8s-logstash-plugins]
99

10-
The power of {{ls}} is in the plugins--{{logstash-ref}}/input-plugins.html[inputs], [outputs](https://www.elastic.co/guide/en/logstash/current/output-plugins.html), [filters,](https://www.elastic.co/guide/en/logstash/current/filter-plugins.html) and [codecs](https://www.elastic.co/guide/en/logstash/current/codec-plugins.html).
10+
The power of {{ls}} is in the plugins--[inputs](https://www.elastic.co/guide/en/logstash/current/input-plugins.html), [outputs](https://www.elastic.co/guide/en/logstash/current/output-plugins.html), [filters,](https://www.elastic.co/guide/en/logstash/current/filter-plugins.html) and [codecs](https://www.elastic.co/guide/en/logstash/current/codec-plugins.html).
1111

1212
In {{ls}} on ECK, you can use the same plugins that you use for other {{ls}} instances—​including Elastic-supported, community-supported, and custom plugins. However, you may have other factors to consider, such as how you configure your {{k8s}} resources, how you specify additional resources, and how you scale your {{ls}} installation.
1313

deploy-manage/deploy/elastic-cloud/manage-integrations-server.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ The APM secret token can no longer be reset from the Elasticsearch Service UI. C
2828

2929
This example demonstrates how to use the Elasticsearch Service RESTful API to create a deployment with Integrations Server enabled.
3030

31-
For more information on how to manage Integrations Server from the UI, check [Manage your Integrations Server]()
32-
3331

3432
#### Requirements [ec_requirements_2]
3533

deploy-manage/distributed-architecture/discovery-cluster-formation/modules-discovery-bootstrap-cluster.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ By default each node will automatically bootstrap itself into a single-node clus
7474
* `discovery.seed_hosts`
7575
* `cluster.initial_master_nodes`
7676

77-
To add a new node into an existing cluster, configure `discovery.seed_hosts` or other relevant discovery settings so that the new node can discover the existing master-eligible nodes in the cluster. To bootstrap a new multi-node cluster, configure `cluster.initial_master_nodes` as described in the [section on cluster bootstrapping]() as well as `discovery.seed_hosts` or other relevant discovery settings.
77+
To add a new node into an existing cluster, configure `discovery.seed_hosts` or other relevant discovery settings so that the new node can discover the existing master-eligible nodes in the cluster. To bootstrap a new multi-node cluster, configure `cluster.initial_master_nodes` as described in the section on cluster bootstrapping as well as `discovery.seed_hosts` or other relevant discovery settings.
7878

7979
::::{admonition} Forming a single cluster
8080
:name: modules-discovery-bootstrap-cluster-joining

deploy-manage/monitor/logging-configuration/auditing-search-queries.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ applies:
1111

1212
# Audit Elasticsearch search queries [auditing-search-queries]
1313

14-
There is no [audit event type]() (asciidocalypse://elasticsearch/docs/reference/elasticsearch/elasticsearch-audit-events) specifically dedicated to search queries. Search queries are analyzed and then processed; the processing triggers authorization actions that are audited. However, the original raw query, as submitted by the client, is not accessible downstream when authorization auditing occurs.
14+
There is no [audit event type](asciidocalypse://elasticsearch/docs/reference/elasticsearch/elasticsearch-audit-events) specifically dedicated to search queries. Search queries are analyzed and then processed; the processing triggers authorization actions that are audited. However, the original raw query, as submitted by the client, is not accessible downstream when authorization auditing occurs.
1515

1616
Search queries are contained inside HTTP request bodies, however, and some audit events that are generated by the REST layer, on the coordinating node, can be toggled to output the request body to the audit log. Therefore, one must audit request bodies in order to audit search queries.
1717

deploy-manage/monitor/logging-configuration/configuring-audit-logs.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ When auditing security events, a single client request might generate multiple a
2424
::::
2525

2626
For a complete description of event details and format, refer to the following resources:
27-
* [{{es}} audit events details and schema]() asciidocalypse://elasticsearch/docs/reference/elasticsearch/elasticsearch-audit-events
27+
* [{{es}} audit events details and schema](asciidocalypse://elasticsearch/docs/reference/elasticsearch/elasticsearch-audit-events)
2828
* [{{es}} log entry output format](/deploy-manage/monitor/logging-configuration/logfile-audit-output.md#audit-log-entry-format)
2929

3030
### Kibana auditing configuration

deploy-manage/monitor/logging-configuration/correlating-kibana-elasticsearch-audit-logs.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ When an {{es}} request generates multiple audit events across multiple nodes, yo
2424

2525
This identifier allows you to trace the flow of a request across the {{es}} cluster and reconstruct the full context of an operation.
2626

27-
Refer to [linkTBD]() asciidocalypse://elasticsearch/docs/reference/elasticsearch/elasticsearch-audit-events for a complete reference of event types and attributes.
27+
Refer to [Audit events](asciidocalypse://elasticsearch/docs/reference/elasticsearch/elasticsearch-audit-events) for a complete reference of event types and attributes.
2828

2929
## `trace.id` field in {{kib}} audit events
3030

0 commit comments

Comments
 (0)