Skip to content

Conversation

karenzone
Copy link
Contributor

@karenzone karenzone commented Aug 18, 2025

@karenzone karenzone self-assigned this Aug 18, 2025
@karenzone karenzone requested a review from shmsr August 18, 2025 16:05
Copy link

github-actions bot commented Aug 18, 2025

🔍 Preview links for changed docs

@karenzone karenzone marked this pull request as ready for review August 18, 2025 17:02
@karenzone karenzone requested a review from a team as a code owner August 18, 2025 17:02
@karenzone
Copy link
Contributor Author

@shmsr, please review. Do we need approvals from any other people or teams?


These Elastic Integrations have components that are **not** FIPS compatible, and **cannot** be used in FIPS environments, even if combined with other ingest tools that offer FIPS mode.

- [Azure Logs Integration (v2 preview)](integration-docs://reference/azure/events.md)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we choose wether or not to include integration in these titles, then do it consistently?

Copy link
Contributor Author

@karenzone karenzone Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link text accurately reflects the target page title. I've updated the link text for consistency, and also opened integration-docs#859 to address inconsistencies in the target content.

- [Custom Azure Logs](integration-docs://reference/azure_logs.md)
- [Azure Resource Metrics Integration](integration-docs://reference/azure_metrics.md)
- [Azure OpenAI Integration](integration-docs://reference/azure_openai.md)
- [SQL Input](integration-docs://reference/sql.md)
Copy link
Contributor

@kilfoyle kilfoyle Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [SQL Input](integration-docs://reference/sql.md)
- [SQL input](integration-docs://reference/sql.md)

Just if you want to exactly match the integration name, but maybe the name should be capitalized. Either way. :-)
Feel free to ignore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, David. Tracking the fix in https://github.com/elastic/integration-docs/issues/859 to address inconsistencies in the target content.

Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ⛵

@lalit-satapathy
Copy link

@shmsr, please review. Do we need approvals from any other people or teams?

CC: @tommyers-elastic

Copy link

@mykola-elastic mykola-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! (covering for @shmsr while he is no PTO)

@karenzone karenzone merged commit 179b657 into elastic:main Aug 21, 2025
7 checks passed
@karenzone karenzone deleted the 2367-non-fips branch August 21, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants