[Lens] Page for Metric charts #3645
Conversation
🔍 Preview links for changed docs |
florent-leborgne
changed the base branch from
main
to
chart-project-integration-branch
florent-leborgne
changed the base branch from
chart-project-integration-branch
to
main
florent-leborgne
requested review from
alaudazzi,
markov00 and
nastasha-solomon
teresaalvarezsoler
left a comment
teresaalvarezsoler
left a comment
There was a problem hiding this comment.
Hey @florent-leborgne great progress on this. I just left a few comments.
…ak down by option
|
Updated to take first round of feedback from @teresaalvarezsoler and @gvnmagni into account |
markov00
left a comment
markov00
left a comment
There was a problem hiding this comment.
Great works here folks!
I've added some minor comments, but the overall page looks great.
Is way more readable, way more clear and precise then ever.
|
|
||
| Metric charts make important single values stand out on a dashboard. They're perfect for highlighting KPIs such as error rates or SLOs for example, and for making them understandable at a glance with dynamic coloring or trend indicators. | ||
|
|
||
| They work with any numeric data: plain numbers, percentages, or calculations like a count, sum, or average. You can get this numeric data from numeric fields stored in your {{es}} documents, or from aggregation functions and formulas that you can apply to any type of field. |
There was a problem hiding this comment.
note that you can also display strings by using the Last Value aggregation that picks up the last document, sorted by timestamp, in the current tine frame.
This is actually great to show the last event, the last status notified of a system/machine/app
There was a problem hiding this comment.
Oh nice, do you have a practical example in mind that I could show? I'm not sure what I could do with the sample data. Still, I added a sentence to explain this. Thanks!
There was a problem hiding this comment.
A pratical example can be: show the last failing service in the current time frame, or the last error message, or the last failing server name/ip
nastasha-solomon
left a comment
nastasha-solomon
left a comment
There was a problem hiding this comment.
Left some suggestions and questions that are hopefully helpful. Looks great overall though!
bmorelli25
left a comment
bmorelli25
left a comment
There was a problem hiding this comment.
Great stuff. The structure and flow makes sense. Good approachable examples.
A few additional comments for you.
Co-authored-by: Nastasha Solomon <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]> Co-authored-by: Nastasha Solomon <[email protected]>
|
|
||
| Metric charts make important single values stand out on a dashboard. They're perfect for highlighting KPIs such as error rates or SLOs for example, and for making them understandable at a glance with dynamic coloring or trend indicators. | ||
|
|
||
| They work with any numeric data: plain numbers, percentages, or calculations like a count, sum, or average. You can get this numeric data from numeric fields stored in your {{es}} documents, or from aggregation functions and formulas that you can apply to any type of field. |
There was a problem hiding this comment.
A pratical example can be: show the last failing service in the current time frame, or the last error message, or the last failing server name/ip
|
Thanks all for the helpful reviews, here and offline! I'll merge this now |
5 participants
Fixes #2543
Here is a draft of a page for metrics charts. Would like reviewers to advise on anything missing and inaccuracies in particular for the settings part where there may be more nuance to add in some places.
Let's finetune what we can and once we have a few different chart pages ready, we can release in small batches
Done:
Missing:
refine examples (various use cases but also various configuration setups)Done and checkedvisuals for examplesDone and checkedadd some advanced, undocumented options that don't look so simple for defining valuesDone and checkedRelease plan: