-
Notifications
You must be signed in to change notification settings - Fork 181
Updates AI Assistant reqs for Security, Obs/Search, Agent Builder #3967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
fd5e90d
Updates AI Assistant requirements for Security, Obs/Search, Agent Bui…
benironside 035f328
Updates security page requirements
benironside d0b8b04
fixes build error
benironside 1667e60
incorporates feedback, testing formatting for obs page
benironside 624401e
Update observability-ai-assistant.md
benironside a7a1670
Update observability-ai-assistant.md
benironside 60e7792
Merge branch 'main' into 3693-AI-assistants-setup-privs
benironside File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know function calling is something used in Observability that Security doesn't use. We may want to keep a note that recommends a model that supports function calling or to configure simulated function calling.
I would only think this wouldn't be necessary if all of the models we have connectors for support function calling. @viduni94 maybe you would have some insight into this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks. Curious to hear further input but sounds like adding a note makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reached out to Viduni directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After my conversation with Viduni, I don't think we need to add a note. Recent proprietary models all support function calling, and if the selected model doesn't support function calling, we use simulated function calling so assistant still works.