Skip to content

Conversation

shainaraskas
Copy link
Collaborator

@shainaraskas shainaraskas commented Mar 5, 2025

This PR edits the self-managed content for ES + Kibana.

It's huge (mostly due to simultaneous cleanup + downstream link fixes), but I'd like a review on the following pages:

overview

es

install guides, all lightly restructured and reworked into snippets (they were snippets before but I had to redo them)

ignore:

  • Important system configuration is largely untouched
  • Docker I just split into subpages

note on install docs

imo there's a big gap in these docs around the way you "build" a cluster w/ multiple nodes. I didn't think I could get my head around it and I want to defer it a bit / maybe get some help. I opened an issue here.

kib

ignore:

  • docker largely untouched
  • access kib largely untouched (cute "grant access" section if you're interested)

other

  • air gapped: I kept the other sections in here because I was worried they weren't ported over to the other areas properly. largely untouched
  • tools and APIs: any additional to add?

A note on snippets

I chose to use snippets because this content is largely repetitive. I think we have an opportunity to merge these pages even further (especially the debian and RPM pages), but I was a little nervous to do that this time given the scope of the content. For reviews, feel free to just write notes with screenshots where you find issues in the installation topics because backtracking through the snippets is hard.

Snippets currently don't cleanly work with headings (sidenav breaks), which is why there are more of them than might seem ideal.

@shainaraskas shainaraskas requested a review from eedugon March 10, 2025 21:59
@shainaraskas shainaraskas marked this pull request as ready for review March 10, 2025 21:59
Copy link
Contributor

@eedugon eedugon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks awesome!!! Really awesome!

@shainaraskas shainaraskas merged commit 03276a3 into main Mar 13, 2025
4 checks passed
@shainaraskas shainaraskas deleted the self-managed branch March 13, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants