Skip to content

Commit 73839c5

Browse files
committed
updated PR according to reviews
1 parent 8109bf6 commit 73839c5

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

.github/workflows/maven-goal/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ runs:
2525
java-version-file: .java-version
2626
distribution: ${{ inputs.distribution }}
2727
cache: 'maven'
28-
- run: "$COMMAND"
28+
- run: "${COMMAND}"
2929
shell: ${{ inputs.shell }}
3030
env:
3131
COMMAND: ${{ inputs.command }}

.github/workflows/pre-post-release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,13 +99,13 @@ jobs:
9999
- name: Push the ${{ inputs.phase }} release branch
100100
run: |
101101
git add --all
102-
git commit -m "$PHASE release: ecs-logging-java v${{ env.RELEASE_VERSION }}"
102+
git commit -m "${PHASE} release: ecs-logging-java v${{ env.RELEASE_VERSION }}"
103103
git push origin ${{ env.BRANCH_NAME }}
104104
env:
105105
PHASE: ${{ inputs.phase }}
106106

107107
- name: Create the ${{ inputs.phase }} release PR
108-
run: gh pr create --title="$PR_TITLE" --base main --head ${{ env.BRANCH_NAME }} -b "$PR_BODY"
108+
run: gh pr create --title="${PR_TITLE}" --base main --head ${{ env.BRANCH_NAME }} -b "${PR_BODY}"
109109
env:
110110
GH_TOKEN: ${{ steps.get_token.outputs.token }}
111111
PR_TITLE: ${{ inputs.pr_title }}

.github/workflows/validate-tag/action.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@ runs:
1515
id: validate-tag
1616
shell: 'bash'
1717
run: |
18-
if ! [ $(echo "$TAG" | grep -P "(\d{1,2})\.(\d{1,2})\.(\d{1,2})") ]; then
18+
if ! [ $(echo "${TAG}" | grep -P "(\d{1,2})\.(\d{1,2})\.(\d{1,2})") ]; then
1919
echo "Tag should be a SemVer format"
2020
exit 1
2121
fi
22-
if [ $(git tag -l "$TAG") ]; then
23-
echo "The tag $TAG already exists"
22+
if [ $(git tag -l "${TAG}") ]; then
23+
echo "The tag ${TAG} already exists"
2424
exit 1
2525
fi
2626
env:

0 commit comments

Comments
 (0)