Skip to content

Commit 16a11e8

Browse files
authored
test: fix winston TAV tests, raise min-supported Winston to 3.3.3 (#162)
The version specifier was originally 3.3.3 and now I wonder if that was for a good reason. While attempting to TAV test with node v14 I get timeouts attempting to install [email protected].
1 parent cfb344f commit 16a11e8

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

docs/winston.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ This Node.js package provides a formatter for the https://github.com/winstonjs/w
55
logger, compatible with {ecs-logging-ref}/intro.html[Elastic Common Schema (ECS) logging].
66
In combination with the https://www.elastic.co/beats/filebeat[Filebeat] shipper,
77
you can https://www.elastic.co/log-monitoring[monitor all your logs] in one
8-
place in the Elastic Stack. `winston` 3.x versions are supported.
8+
place in the Elastic Stack. `winston` 3.x versions >=3.3.3 are supported.
99

1010

1111
[float]

packages/ecs-winston-format/.tav.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
1+
# - Skip [email protected], it breaks errors.test.js. Fixed in 3.7.2.
2+
# - Min supported is [email protected], because I had timeouts even installing
3+
# [email protected] with node v14.
14
winston:
2-
- versions: '>=3.0.0 <3.6.0'
5+
- versions: '>=3.3.3 <3.6.0'
36
node: '>=6.4.0'
47
commands: 'npm test'
5-
- versions: '>=3.6.0'
8+
- versions: '>=3.6.0 <3.7.1 || >3.7.1'
69
node: '>=12'
710
commands: 'npm test'

packages/ecs-winston-format/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@
5454
"split2": "^3.2.2",
5555
"standard": "16.x",
5656
"tap": "^15.0.10",
57+
"test-all-versions": "^5.0.1",
5758
"winston": "^3.3.3"
5859
}
5960
}

0 commit comments

Comments
 (0)