tests(helpers): add http formatter tests for Express objects

Author: trentm

helpers/README.md

@@ -82,7 +82,10 @@ for winston.
 ### `formatHttpRequest`
 
 Function that enhances an ECS object with http request data.
-The request object should be Node.js's core request object.
+The request object should be Node.js's core
+[`http.IncomingMessage`](https://nodejs.org/api/all.html#http_class_http_incomingmessage),
+or [Express's request object](https://expressjs.com/en/5x/api.html#req) that
+extends it.
 
 ```js
 const { formatHttpRequest } = require('@elastic/ecs-helpers')
@@ -105,7 +108,10 @@ console.log(ecs)
 ### `formatHttpResponse`
 
 Function that enhances an ECS object with http response data.
-The response object should be Node.js's core response object.
+The response object should be Node.js's core
+[`http.ServerResponse`](https://nodejs.org/api/all.html#http_class_http_serverresponse),
+or [Express's response object](https://expressjs.com/en/5x/api.html#res) that
+extends it.
 
 ```js
 const { formatHttpResponse } = require('@elastic/ecs-helpers')

helpers/package.json

@@ -17,7 +17,7 @@
   },
   "homepage": "https://github.com/elastic/ecs-logging-nodejs/blob/master/helpers/README.md",
   "scripts": {
-    "test": "standard && tap --timeout ${TAP_TIMEOUT:-10} test.js"
+    "test": "standard && tap --timeout ${TAP_TIMEOUT:-10} test/*.test.js"
   },
   "engines": {
     "node": ">=10"
@@ -28,6 +28,7 @@
   "devDependencies": {
     "ajv": "^7.0.3",
     "ajv-formats": "^1.5.1",
+    "express": "^4.17.1",
     "semver": "^7.1.3",
     "standard": "16.x",
     "tap": "^14.x"

helpers/test.js renamed to helpers/test/basic.test.js

@@ -24,22 +24,22 @@ const Ajv = require('ajv').default
 const semver = require('semver')
 const test = require('tap').test
 
-const { ecsLoggingValidate } = require('../utils/lib/ecs-logging-validate')
+const { ecsLoggingValidate } = require('../../utils/lib/ecs-logging-validate')
 
 const {
   version,
   stringify,
   formatError,
   formatHttpRequest,
   formatHttpResponse
-} = require('./')
+} = require('../')
 
 const ajv = new Ajv({
   allErrors: true,
   verbose: true
 })
 addFormats(ajv)
-const validate = ajv.compile(require('../utils/schema.json'))
+const validate = ajv.compile(require('../../utils/schema.json'))
 
 test('stringify should return a valid ecs json', t => {
   const ecsFields = {