Migrate Jenkinsfile to GH Actions Workflow (#132)

* Migrate Jenkinsfile to GH Actions Workflow

* Retrigger CI

* Fix indent

* Fix workflow

* Set fail-fast to false

* Add cache

* hm

* Cache does not work without package-lock.json

* Add newer versions

* Revert "Add newer versions"

This reverts commit ccfcc82.

* Add newline at EOF

* Update .github/workflows/test.yml

* fix tests to work with node >=v17 where 'localhost' no longer prefers to resolve to 127.0.0.1

* Fix response headers in Node v19

Since v19 the connection=keep-alive header is set by default.
See: https://nodejs.org/en/blog/announcements/v19-release-announce/#http-s-1-1-keepalive-by-default

* Remove Jenkins related files

* Refactor connection header

* Fix formatting

Co-authored-by: Trent Mick <[email protected]>

Author: reakaleek

.ci/Jenkinsfile

@@ -0,0 +1,31 @@
+## Test with multiple node versions.
+name: test
+
+on:
+  push:
+    branches:
+      - main
+    tags:
+  pull_request:
+    branches:
+      - main
+
+permissions:
+  contents: read
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        node-version: [10, 12, 14, 16, 18, 19]
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node-version }}
+      - name: Install dependencies
+        run: .ci/run-install.sh
+      - name: Test Node.js v${{ matrix.node-version }}
+        run: .ci/run-test.sh

.ci/jobs/defaults.yml

@@ -100,15 +100,16 @@ test('bad ECS json on purpose: message type, ecs.version missing', t => {
 
 test('formatHttpRequest and formatHttpResponse should return a valid ecs object', t => {
   const server = http.createServer(handler)
-  server.listen(0, () => {
+  server.listen(0, '127.0.0.1', () => {
     const body = JSON.stringify({ hello: 'world' })
     const req = http.request(
-      `http://localhost:${server.address().port}/hello/world?foo=bar`,
+      `http://127.0.0.1:${server.address().port}/hello/world?foo=bar`,
       {
         method: 'POST',
         body,
         headers: {
           'user-agent': 'cool-agent',
+          connection: 'close',
           'content-type': 'application/json',
           'content-length': Buffer.byteLength(body)
         }
@@ -158,7 +159,7 @@ test('formatHttpRequest and formatHttpResponse should return a valid ecs object'
     t.same(line.url, {
       path: '/hello/world',
       query: 'foo=bar',
-      full: `http://localhost:${server.address().port}/hello/world?foo=bar#anchor`,
+      full: `http://127.0.0.1:${server.address().port}/hello/world?foo=bar#anchor`,
       fragment: 'anchor'
     })
     t.same(line.http, {
@@ -169,7 +170,7 @@ test('formatHttpRequest and formatHttpResponse should return a valid ecs object'
           'user-agent': 'cool-agent',
           'content-type': 'application/json',
           'content-length': '17',
-          host: `localhost:${server.address().port}`,
+          host: `127.0.0.1:${server.address().port}`,
           connection: 'close'
         },
         body: { bytes: 17 }
@@ -185,8 +186,7 @@ test('formatHttpRequest and formatHttpResponse should return a valid ecs object'
     })
     // https://www.elastic.co/guide/en/ecs/current/ecs-client.html fields
     t.ok(line.client, 'client fields are set')
-    t.ok(line.client.address === '127.0.0.1' || line.client.address === '::ffff:127.0.0.1',
-      'client.address is set')
+    t.ok(line.client.address === '127.0.0.1', 'client.address is set')
     t.ok(line.client.ip === line.client.address,
       'client.address duplicated to client.ip')
     t.equal(typeof (line.client.port), 'number')

.ci/jobs/ecs-logging-nodejs-mbp.yml

@@ -46,16 +46,16 @@ test('express res/req serialization', t => {
     t.same(rec.user_agent, { original: 'cool-agent' })
     t.same(rec.url, {
       path: '/',
-      full: `http://localhost:${server.address().port}/`,
-      domain: 'localhost'
+      full: `http://127.0.0.1:${server.address().port}/`,
+      domain: '127.0.0.1'
     })
     t.same(rec.http, {
       version: '1.1',
       request: {
         method: 'GET',
         headers: {
           'user-agent': 'cool-agent',
-          host: `localhost:${server.address().port}`,
+          host: `127.0.0.1:${server.address().port}`,
           connection: 'close'
         }
       },
@@ -69,19 +69,18 @@ test('express res/req serialization', t => {
     })
     // https://www.elastic.co/guide/en/ecs/current/ecs-client.html fields
     t.ok(rec.client, 'client fields are set')
-    t.ok(rec.client.address === '127.0.0.1' || rec.client.address === '::ffff:127.0.0.1',
-      'client.address is set')
+    t.ok(rec.client.address === '127.0.0.1', 'client.address is set')
     t.ok(rec.client.ip === rec.client.address,
       'client.address duplicated to client.ip')
     t.equal(typeof (rec.client.port), 'number')
   })
 
-  app.listen(0, function () {
+  app.listen(0, '127.0.0.1', function () {
     server = this
     const req = http.get(
-      `http://localhost:${server.address().port}/`,
+      `http://127.0.0.1:${server.address().port}/`,
       {
-        headers: { 'user-agent': 'cool-agent' }
+        headers: { 'user-agent': 'cool-agent', connection: 'close' }
       },
       function (res) {
         res.on('data', function () {})

.github/workflows/test.yml

@@ -35,7 +35,7 @@ const testOpts = {
 
 test('hapi res/req serialization', testOpts, t => {
   const Hapi = require('@hapi/hapi')
-  const server = Hapi.server({ host: 'localhost' })
+  const server = Hapi.server({ host: '127.0.0.1' })
 
   server.route({
     method: 'GET',
@@ -56,15 +56,15 @@ test('hapi res/req serialization', testOpts, t => {
     t.same(rec.user_agent, { original: 'cool-agent' })
     t.same(rec.url, {
       path: '/',
-      full: `http://localhost:${server.info.port}/`
+      full: `http://127.0.0.1:${server.info.port}/`
     })
     t.same(rec.http, {
       version: '1.1',
       request: {
         method: 'GET',
         headers: {
           'user-agent': 'cool-agent',
-          host: `localhost:${server.info.port}`,
+          host: `127.0.0.1:${server.info.port}`,
           connection: 'close'
         }
       },
@@ -84,8 +84,7 @@ test('hapi res/req serialization', testOpts, t => {
     })
     // https://www.elastic.co/guide/en/ecs/current/ecs-client.html fields
     t.ok(rec.client, 'client fields are set')
-    t.ok(rec.client.address === '127.0.0.1' || rec.client.address === '::ffff:127.0.0.1',
-      'client.address is set')
+    t.ok(rec.client.address === '127.0.0.1', 'client.address is set')
     t.ok(rec.client.ip === rec.client.address,
       'client.address duplicated to client.ip')
     t.equal(typeof (rec.client.port), 'number')
@@ -99,8 +98,8 @@ test('hapi res/req serialization', testOpts, t => {
     t.comment('hapi server running on %s', server.info.uri)
 
     // Make a request so we trigger a 'response' event above.
-    const req = http.get(`http://localhost:${server.info.port}/`,
-      { headers: { 'user-agent': 'cool-agent' } })
+    const req = http.get(`http://127.0.0.1:${server.info.port}/`,
+      { headers: { 'user-agent': 'cool-agent', connection: 'close' } })
     req.on('error', t.ifErr)
   })
 })