From acd34272fe8806bb00f6dfc6b35e934fa3f4610b Mon Sep 17 00:00:00 2001 From: Trent Mick Date: Mon, 10 Mar 2025 12:06:04 -0700 Subject: [PATCH] chore(slack-lite): switch to pull_request_target so have access to repo secrets No need for us to be running code from the PR itself, so this event is fine. Before this change, a workflow run for a PR from a *fork* would have 'Secret source: None' and hence not have access to the SLACK_BOT_TOKEN Also be clearer on the 'slack-lite' brand. Refs: https://github.com/elastic/apm-agent-nodejs/pull/4501 --- .github/workflows/{slack.yml => slack-lite.yml} | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) rename .github/workflows/{slack.yml => slack-lite.yml} (98%) diff --git a/.github/workflows/slack.yml b/.github/workflows/slack-lite.yml similarity index 98% rename from .github/workflows/slack.yml rename to .github/workflows/slack-lite.yml index 3de2851..53189fd 100644 --- a/.github/workflows/slack.yml +++ b/.github/workflows/slack-lite.yml @@ -11,7 +11,7 @@ # 3. Optionally tweak the `if:` and `on:` sections below to control which issue # and PR events are skipped. -name: slack +name: slack-lite env: SLACK_CHANNEL: "#apm-agent-node" @@ -19,11 +19,11 @@ env: on: issues: types: [opened, reopened, closed] - pull_request: + pull_request_target: types: [opened, ready_for_review, reopened, closed] jobs: - slack: + slack-lite: # Skip notification if: # - dependabot or renovate PRs, too noisy # - draft PRs