fix: ignore os.IsNotExist error when removing stale UNIX socket (#316)

* fix: ignore os.IsNotExist error when removing stale UNIX socket

* fix: remove comment for unused linter "nakedret"

* fix: directly call os.Remove

Author: pkoutsovasilis

api/make_listener_posix.go

@@ -47,10 +47,8 @@ func makeListener(cfg Config) (net.Listener, error) {
 	}
 
 	if network == unixNetwork {
-		if _, err := os.Stat(path); !os.IsNotExist(err) {
-			if err := os.Remove(path); err != nil {
-				return nil, fmt.Errorf("cannot remove existing unix socket file at location %s: %w", path, err)
-			}
+		if err := os.Remove(path); err != nil && !os.IsNotExist(err) {
+			return nil, fmt.Errorf("cannot remove existing unix socket file at location %s: %w", path, err)
 		}
 	}
 

api/server.go

@@ -123,7 +123,7 @@ func (s *Server) AttachHandler(route string, h http.Handler) (err error) {
 	}()
 	s.log.Infof("Attempting to attach %q to server.", route)
 	s.mux.Handle(route, h)
-	return //nolint:nakedret // returning from recover
+	return // returning from recover
 }
 
 func parse(host string, port int) (string, string, error) {