Skip to content

Commit 2a4dfe3

Browse files
authored
Disable stack traces for development/testing logger (#331)
1 parent f3b61a6 commit 2a4dfe3

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

logp/logger.go

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,12 +72,18 @@ func NewProductionLogger(selector string, options ...LogOption) (*Logger, error)
7272
// NewDevelopmentLogger returns a development suitable logp.Logger
7373
func NewDevelopmentLogger(selector string, options ...LogOption) (*Logger, error) {
7474
options = append([]LogOption{zap.AddCallerSkip(1)}, options...)
75-
log, err := zap.NewDevelopment(options...)
76-
log = log.Named(selector)
75+
config := zap.NewDevelopmentConfig()
76+
// if not disabled it shows stacktrace for warn, error level - which can be mistaken for a panic
77+
config.DisableStacktrace = true
78+
logger, err := config.Build(options...)
7779
if err != nil {
7880
return nil, err
7981
}
80-
return &Logger{log, log.Sugar()}, nil
82+
logger = logger.Named(selector)
83+
if err != nil {
84+
return nil, err
85+
}
86+
return &Logger{logger, logger.Sugar()}, nil
8187
}
8288

8389
// NewInMemory returns a new in-memory logger along with the buffer to which it

0 commit comments

Comments
 (0)