make logger on TLSConfig global (#336)

* make logger on TLSConfig global

* fix test conditions

Author: khushijain21

transport/tlscommon/config.go

@@ -88,7 +88,7 @@ func LoadTLSConfig(config *Config, logger *logp.Logger) (*TLSConfig, error) {
 		Renegotiation:        tls.RenegotiationSupport(config.Renegotiation),
 		CASha256:             config.CASha256,
 		CATrustedFingerprint: config.CATrustedFingerprint,
-		logger:               logger,
+		Logger:               logger,
 	}, nil
 }
 

transport/tlscommon/server_config.go

@@ -96,7 +96,7 @@ func LoadTLSServerConfig(config *ServerConfig, logger *logp.Logger) (*TLSConfig,
 		CurvePreferences: curves,
 		ClientAuth:       tls.ClientAuthType(clientAuth),
 		CASha256:         config.CASha256,
-		logger:           logger,
+		Logger:           logger,
 	}, nil
 }
 

transport/tlscommon/tls_config.go

@@ -87,7 +87,7 @@ type TLSConfig struct {
 	// If time is nil, TLS uses time.Now.
 	time func() time.Time
 
-	logger *logp.Logger
+	Logger *logp.Logger
 }
 
 var (
@@ -106,7 +106,7 @@ func (c *TLSConfig) ToConfig() *tls.Config {
 
 	insecure := c.Verification != VerifyStrict
 	if c.Verification == VerifyNone {
-		c.logger.Named("tls").Warn("SSL/TLS verifications disabled.")
+		c.Logger.Named("tls").Warn("SSL/TLS verifications disabled.")
 	}
 
 	return &tls.Config{
@@ -121,7 +121,7 @@ func (c *TLSConfig) ToConfig() *tls.Config {
 		Renegotiation:      c.Renegotiation,
 		ClientAuth:         c.ClientAuth,
 		Time:               c.time,
-		VerifyConnection:   makeVerifyConnection(c, c.logger),
+		VerifyConnection:   makeVerifyConnection(c, c.Logger),
 	}
 }
 

transport/tlscommon/tls_config_test.go

@@ -651,7 +651,7 @@ func TestVerificationMode(t *testing.T) {
 				Verification: test.verificationMode,
 				RootCAs:      certPool,
 				ServerName:   test.hostname,
-				logger:       logptest.NewTestingLogger(t, ""),
+				Logger:       logptest.NewTestingLogger(t, ""),
 			}
 
 			if test.ignoreCerts {
@@ -674,6 +674,8 @@ func TestVerificationMode(t *testing.T) {
 				if err != nil {
 					// We got the expected error, no need to check the status code
 					return
+				} else {
+					t.Fatalf("expected error, got: %v", err)
 				}
 			}