Skip to content

Commit 9d85625

Browse files
authored
Enable linting whole files in Github action (#31)
The linter is supposed to support linting of a changed patch only but, for some reason, it's very unreliable this way - sometimes it does not report any or some issues without linting the whole files, so we have to use `--whole-files`
1 parent 6a4dec0 commit 9d85625

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

.github/workflows/golangci-lint.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,13 @@ jobs:
4646
version: v1.44.2
4747

4848
# Give the job more time to execute.
49-
args: --timeout=5m
49+
# Regarding `--whole-files`, the linter is supposed to support linting of changed a patch only but,
50+
# for some reason, it's very unreliable this way - sometimes it does not report any or some
51+
# issues without linting the whole files, so we have to use `--whole-files`
52+
# which can lead to some frustration from developers who would like to
53+
# fix a single line in an existing codebase and the linter would force them
54+
# into fixing all linting issues in the whole file instead
55+
args: --timeout=30m --whole-files
5056

5157
# Optional: if set to true then the action will use pre-installed Go.
5258
skip-go-installation: true

0 commit comments

Comments
 (0)