Add integration build tag (#258)

mauri870 · web-flow · commit b7b4628fa958 · 2024-12-24T07:10:07.000-03:00
The test TestSyslogOutputCanBeClosed requires no syslog running
on the host and root privileges to execute. Most Linux distros
already have a syslog daemon running, causing test failures
during development. These failures make it difficult to identify
real issues with the tests.

Given this, introduce an integration build tag
and run this test only by default on CI.

The integration build tag was previously used only for negative
matches in certain tests, which is not meaningful. Remove the
!integration annotations.
diff --git a/.buildkite/scripts/test.ps1 b/.buildkite/scripts/test.ps1
@@ -21,7 +21,7 @@ Write-Host "--- Run test"
 $ErrorActionPreference = "Continue" # set +e
 mkdir -p build
 $OUT_FILE="output-report.out"
-go test "./..." -v > $OUT_FILE
+go test -tags integration "./..." -v > $OUT_FILE
 $EXITCODE=$LASTEXITCODE
 $ErrorActionPreference = "Stop"
 
diff --git a/.buildkite/scripts/test.sh b/.buildkite/scripts/test.sh
@@ -11,7 +11,7 @@ with_go_junit_report
 
 echo "--- Go Test"
 set +e
-go test -race -v ./... > tests-report.txt
+go test -tags integration -race -v ./... > tests-report.txt
 exit_code=$?
 set -e
 
diff --git a/file/helper_test.go b/file/helper_test.go
@@ -15,8 +15,6 @@
 // specific language governing permissions and limitations
 // under the License.
 
-//go:build !integration
-
 package file
 
 import (
diff --git a/kibana/url_test.go b/kibana/url_test.go
@@ -15,8 +15,6 @@
 // specific language governing permissions and limitations
 // under the License.
 
-//go:build !integration
-
 package kibana
 
 import (
diff --git a/logp/core_linux_test.go b/logp/core_linux_test.go
@@ -15,7 +15,7 @@
 // specific language governing permissions and limitations
 // under the License.
 
-//go:build linux
+//go:build linux && integration
 
 package logp
 
diff --git a/mapstr/mapstr_test.go b/mapstr/mapstr_test.go
@@ -15,8 +15,6 @@
 // specific language governing permissions and limitations
 // under the License.
 
-//go:build !integration
-
 package mapstr
 
 import (
diff --git a/monitoring/opts_test.go b/monitoring/opts_test.go
@@ -15,8 +15,6 @@
 // specific language governing permissions and limitations
 // under the License.
 
-//go:build !integration
-
 package monitoring
 
 import (
diff --git a/monitoring/registry_test.go b/monitoring/registry_test.go
@@ -15,8 +15,6 @@
 // specific language governing permissions and limitations
 // under the License.
 
-//go:build !integration
-
 package monitoring
 
 import (
diff --git a/monitoring/visitor_expvar_test.go b/monitoring/visitor_expvar_test.go
@@ -15,8 +15,6 @@
 // specific language governing permissions and limitations
 // under the License.
 
-//go:build !integration
-
 package monitoring
 
 import (
diff --git a/transform/typeconv/datetime_test.go b/transform/typeconv/datetime_test.go
@@ -15,8 +15,6 @@
 // specific language governing permissions and limitations
 // under the License.
 
-//go:build !integration
-
 package typeconv
 
 import (
diff --git a/transport/tlscommon/tls_test.go b/transport/tlscommon/tls_test.go
@@ -15,8 +15,6 @@
 // specific language governing permissions and limitations
 // under the License.
 
-//go:build !integration
-
 package tlscommon
 
 import (
