Disable logging when all outputs are disabled (#204)

Author: belimawr

logp/core.go

@@ -211,9 +211,9 @@ func createLogOutput(cfg Config, enab zapcore.LevelEnabler) (zapcore.Core, error
 	case SystemdEnvironment, ContainerEnvironment:
 		return makeStderrOutput(cfg, enab)
 	case MacOSServiceEnvironment, WindowsServiceEnvironment:
-		fallthrough
-	default:
 		return makeFileOutput(cfg, enab)
+	default:
+		return zapcore.NewNopCore(), nil
 	}
 }
 

logp/core_test.go

@@ -612,6 +612,25 @@ func TestTypedLoggerCoreWith(t *testing.T) {
 	}
 }
 
+func TestCreateLogOutputAllDisabled(t *testing.T) {
+	cfg := DefaultConfig(DefaultEnvironment)
+	cfg.toIODiscard = false
+	cfg.toObserver = false
+	cfg.ToEventLog = false
+	cfg.ToFiles = false
+	cfg.ToStderr = false
+	cfg.ToSyslog = false
+
+	out, err := createLogOutput(cfg, zap.DebugLevel)
+	if err != nil {
+		t.Fatalf("did not expect an error calling createLogOutput: %s", err)
+	}
+
+	if out.Enabled(zap.DebugLevel) {
+		t.Fatal("the output must be disabled to all log levels")
+	}
+}
+
 func strField(key, val string) zapcore.Field {
 	return zapcore.Field{Type: zapcore.StringType, Key: key, String: val}
 }